Skip to content

London | 26-ITP-May | Eyob Zeray | Sprint 1 | course work - #1310

Open
eyob-tech wants to merge 5 commits into
CodeYourFuture:mainfrom
eyob-tech:coursework/sprint-1
Open

London | 26-ITP-May | Eyob Zeray | Sprint 1 | course work#1310
eyob-tech wants to merge 5 commits into
CodeYourFuture:mainfrom
eyob-tech:coursework/sprint-1

Conversation

@eyob-tech

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Fixed calculateMedian in fix/median.js to filter out non-numeric values, sort the remaining numbers, and correctly handle empty arrays and even/odd-length arrays.
  • Implemented findMax in implement/max.js, with tests covering empty arrays, single-element arrays, negative numbers, decimals, and non-numeric values.
  • Implemented sum in implement/sum.js, with tests covering the same range of edge cases.
  • Implemented dedupe in implement/dedupe.js, preserving first occurrence of each element, with tests for empty arrays, no-duplicate arrays, strings, and numbers.
  • Refactored includes in refactor/includes.js to use a for...of loop instead of an indexed for loop, with all existing tests still passing.

All tests pass locally (npm test).

@eyob-tech eyob-tech added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. 🏕 Priority Mandatory This work is expected labels Jul 27, 2026

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good use of reduce to solve some of these - task complete

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Data-Groups The name of the module. 🏕 Priority Mandatory This work is expected 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants