Manchester | 26-ITP-May | Abdu Hassen | Sprint 2 | Data-groups - #1313
Open
Abduhasen wants to merge 2 commits into
Open
Manchester | 26-ITP-May | Abdu Hassen | Sprint 2 | Data-groups #1313Abduhasen wants to merge 2 commits into
Abduhasen wants to merge 2 commits into
Conversation
Abduhasen
added
📅 Sprint 2
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Aug 1, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work, still some things to work on
| return false; | ||
| } | ||
| for (const keyProperty in givenObject) { | ||
| console.log(keyString); |
There was a problem hiding this comment.
Why do you need to do console.log here?
| queryParams[pair] = ""; | ||
| } else { | ||
| const key = decodeURIComponent(pair.slice(0, equalityPosition)); | ||
| const replacedKey = key.replace("+", " "); |
There was a problem hiding this comment.
Does this work for examples with multiple +es in a single querystring
| word key and pairing it withe the last loop value. */ | ||
|
|
||
| // e) Fix the implementation of invert (and write tests to prove it's fixed!) | ||
| /* function invert(obj) { |
There was a problem hiding this comment.
Can you un-comment this, comment the broken original, and then try writing some tests to see if this is correct?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…based on tdd
Learners, PR Template
Self checklist
Changelist
-fixing code based on test
-writing codes based on test driven development
-writing tests
Questions
N/A