Birmingham | 26-ITP-May | Toluwalase Tiamiyu | Sprint 2 | Coursework - #1317
Open
TTiamiyu wants to merge 16 commits into
Open
Birmingham | 26-ITP-May | Toluwalase Tiamiyu | Sprint 2 | Coursework#1317TTiamiyu wants to merge 16 commits into
TTiamiyu wants to merge 16 commits into
Conversation
…ing and handle edge cases
…t from country-currency pairs
…ameters, and support duplicate keys; add corresponding tests for edge cases
…nd organize test structure for clarity
…d handle non-array inputs
…dation for non-object types
…le invalid inputs
TTiamiyu
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Aug 1, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work, still some things to work on
| @@ -1,3 +1,8 @@ | |||
| function contains() {} | |||
| function contains() { | |||
There was a problem hiding this comment.
Have you tried running the tests? Is there anything missing?
Author
There was a problem hiding this comment.
thank you for point that out, on closer look i made a mistake in the function, no parameters were passed, rectified the the code and the test passes all cases now
LonMcGregor
added
Reviewed
…syntax error in test case
…ty and consistency
TTiamiyu
added
the
Needs Review
LonMcGregor
reviewed
Aug 3, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work, the contains is now fixed. Have you tried running the tests yourself? I think the same problem exists in other files.
LonMcGregor
removed
the
Needs Review
TTiamiyu
added
the
Needs Review
LonMcGregor
added
Complete
This was referenced Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist