Skip to content

West Midlands | May 2026 | Muhammad-Burhan Mustafa | Sprint 2 | Wireframe#1379

Open
burhan-mustafa wants to merge 4 commits into
CodeYourFuture:mainfrom
burhan-mustafa:Wireframe-2.0
Open

West Midlands | May 2026 | Muhammad-Burhan Mustafa | Sprint 2 | Wireframe#1379
burhan-mustafa wants to merge 4 commits into
CodeYourFuture:mainfrom
burhan-mustafa:Wireframe-2.0

Conversation

@burhan-mustafa
Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I have amended the following code inline with README file. There are three articles with links to seperate articles.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 31, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 478794e
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a1c6ea52f9fe50008a6c79e
😎 Deploy Preview https://deploy-preview-1379--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 98 (🔴 down 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@burhan-mustafa burhan-mustafa added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 2 Assigned during Sprint 2 of this module Module-Onboarding The name of the module. labels May 31, 2026
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is free of error, and page layout matches the wireframe well. Good job.


One of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", has not yet been satisfied. Can you make the necessary change? (Suggestion: Ask AI what that requirement means).

Comment thread Wireframe/wireframe.html
<img src="./images/wireframes.png" alt="">
<h2>What is the purpose of a Wireframe?</h2>
<p>
A wireframe is used as a structural blueprint that allows a developer to envision how a project will look.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supposedly this paragraph is what is expected in the "article summary".

No change needed.

Comment thread Wireframe/style.css

article p {
margin-top:4px;
}
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the code is not formatted by an automated tool.

Can you follow this guide to enable VS Code's
"Format on Save" option or to use its "Format Document" command to format your HTML and CSS code?

Note: I meant to select the codes on lines 107-113.

Comment thread Wireframe/index.html
<article>
<img src="placeholder.svg" alt="" />
<h2>Title</h2>
<img src="./images/branch.png" alt="">
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Providing meaningful alt text is important because it ensures images are accessible to people using screen readers and also helps when images fail to load, giving users essential context about the content or function of the image.

Can you give a more descriptive alt value to all images?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Onboarding The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants