Skip to content

London | 26-ITP-May | Vito Moratti | Sprint 2 | Feature/Wireframe#1397

Open
vmoratti wants to merge 13 commits into
CodeYourFuture:mainfrom
vmoratti:feature/Wireframe
Open

London | 26-ITP-May | Vito Moratti | Sprint 2 | Feature/Wireframe#1397
vmoratti wants to merge 13 commits into
CodeYourFuture:mainfrom
vmoratti:feature/Wireframe

Conversation

@vmoratti
Copy link
Copy Markdown

@vmoratti vmoratti commented Jun 1, 2026

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I had to delete all the previous branches and redo it from scratch.

@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 1, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 7139bda
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a23e65c6bc5080008e03af9
😎 Deploy Preview https://deploy-preview-1397--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 96 (🔴 down 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@vmoratti vmoratti added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 1, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 1, 2026
@github-actions

This comment has been minimized.

Sign in to view
@vmoratti vmoratti changed the title London | 26-ITP-May | Vito Moratti | Sprint 1 | feature/Wireframe London | 26-ITP-May | Vito Moratti | Sprint 1 | Feature/Wireframe Jun 1, 2026
@github-actions

This comment has been minimized.

Sign in to view
@vmoratti vmoratti changed the title London | 26-ITP-May | Vito Moratti | Sprint 1 | Feature/Wireframe London | 26-ITP-May | Vito Moratti | Sprint 2 | Feature/wireframe Jun 1, 2026
@github-actions

This comment has been minimized.

Sign in to view
@vmoratti vmoratti added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 1, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 1, 2026
@vmoratti vmoratti changed the title London | 26-ITP-May | Vito Moratti | Sprint 2 | Feature/wireframe London | 26-ITP-May | Vito Moratti | Sprint 2 | Feature/Wireframe Jun 2, 2026
@github-actions

This comment has been minimized.

Sign in to view
@vmoratti vmoratti added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 2, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 2, 2026
@vmoratti vmoratti added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 3, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 3, 2026
@vmoratti vmoratti added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 3, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 3, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 3, 2026
@akeren akeren added 📅 Sprint 2 Assigned during Sprint 2 of this module Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Module-Onboarding The name of the module. labels Jun 5, 2026
@akeren akeren self-requested a review June 5, 2026 11:37
@github-actions

This comment has been minimized.

Sign in to view
2 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@akeren
Copy link
Copy Markdown

akeren commented Jun 5, 2026

@vmoratti, review the comments and resolve the issues highlighted...

@vmoratti
Copy link
Copy Markdown
Author

vmoratti commented Jun 5, 2026

I have tried to resolve it. Please advice.

akeren
akeren reviewed Jun 5, 2026
View reviewed changes
Comment thread Wireframe/index.html
Comment on lines +12 to +22
<header>
<h1>Wireframe</h1>
<p>
This page will show:
</p>
<ul>
<li>Purpose of README file</li>
<li>Purpose of Wireframe</li>
<li>What is branch in Git</li>
</ul>
</header>
Copy link
Copy Markdown

@akeren akeren Jun 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vmoratti, compare the header with the main section of the page. Does the alignment look intentional? What CSS change might help align them?

Copy link
Copy Markdown
Author

@vmoratti vmoratti Jun 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made adjustments. The header section is centered now.

Comment thread Wireframe/index.html Outdated
It allows you to diverge from the mainline of development and work on features, experiments, or bug fixes
without affecting the main codebase.
</p>
<a href="https://en.wikipedia.org/wiki/Git_branch">Read more</a>
Copy link
Copy Markdown

@akeren akeren Jun 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vmoratti, why is this UI experience not the same as the rest of the links?

Copy link
Copy Markdown
Author

@vmoratti vmoratti Jun 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed the link to more information about git branch.

Copy link
Copy Markdown

@akeren akeren Jun 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vmoratti, I am referring to the appearance of the button. Compare it with the rest. Think of what has to change to make it appear the same as the rest.

Copy link
Copy Markdown
Author

@vmoratti vmoratti Jun 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added max-height to the anchor element in CSS file. "Read more" buttons appear the same size now.

@akeren
Copy link
Copy Markdown

akeren commented Jun 5, 2026

I have tried to resolve it. Please advice.

@vmoratti, please try and follow these instructions 👉 https://deploy-preview-1397--cyf-onboarding-module.netlify.app/Wireframe/readme.md

@akeren akeren added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jun 5, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@vmoratti vmoratti added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 5, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 5, 2026
@vmoratti vmoratti added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 5, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 5, 2026
@vmoratti vmoratti force-pushed the feature/Wireframe branch from 38bfb5f to 874f846 Compare June 6, 2026 09:19
@vmoratti vmoratti added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 🏕 Priority Mandatory This work is expected labels Jun 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@akeren akeren akeren left review comments

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

@vmoratti vmoratti

Labels

Module-Onboarding The name of the module. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 🏕 Priority Mandatory This work is expected Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vmoratti @akeren