London | 26-ITP-May | Talia Kucuk | Sprint 2 | Wireframe#1399
Open
TaliaKucuk wants to merge 11 commits into
Open
London | 26-ITP-May | Talia Kucuk | Sprint 2 | Wireframe#1399TaliaKucuk wants to merge 11 commits into
TaliaKucuk wants to merge 11 commits into
Conversation
…ranch" This reverts commit 0902c84.
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
TaliaKucuk
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
TaliaKucuk
added
the
Needs Review
cjyuan
reviewed
Jun 5, 2026
Contributor
There was a problem hiding this comment.
Code is well formatted and error-free, and page layout match the wireframe well. Good job!
-
One of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", has not yet been satisfied. Can you make the necessary change? (Suggestion: Ask AI what that requirement means).
- After you have made the footer fixed, please also ensure the footer and the article text content won't overlap.
-
Your PR description is missing a "Changelist section". See this guide for more info.
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist