Skip to content

Manchester | 26-ITP-Sep | Salah Alsabhi | Sprint 3 | Refactoring Dead Code - #1744

Open
salahalsabhi wants to merge 1 commit into
CodeYourFuture:mainfrom
salahalsabhi:coursework/sprint-3-dead-code
Open

salahalsabhi wants to merge 1 commit into
CodeYourFuture:mainfrom
salahalsabhi:coursework/sprint-3-dead-code

Conversation

@salahalsabhi

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1066

Changelist

Remove dead code from exercise-1 and exercise-2.

Questions

No questions

@github-actions

This comment has been minimized.

@salahalsabhi salahalsabhi changed the title Manchester | 26-ITP-Sep | Salah Alsabhi | Sprint-3 | Refactoring Dead Code Manchester | 26-ITP-Sep | Salah Alsabhi | Sprint-3 | Dead Code Oct 21, 2026
@github-actions

This comment has been minimized.

@salahalsabhi salahalsabhi changed the title Manchester | 26-ITP-Sep | Salah Alsabhi | Sprint-3 | Dead Code Manchester | 26-ITP-Sep | Salah Alsabhi | Sprint 3 | Refactoring Dead Code Oct 21, 2026
@salahalsabhi salahalsabhi added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 21, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Comment thread dead-code/exercise-1.js
testName = "Aman";

const greetingMessage = sayHello(greeting, testName);
console.log(sayHello("hello", "Aman")); // 'hello, Aman!'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supposedly the objective is to remove dead code instead of refactoring the code.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted...Thank you for the review .

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants