London | 26-SDC-Mar | Khilola Rustamova| Sprint 4 |Implement cowsay#503
London | 26-SDC-Mar | Khilola Rustamova| Sprint 4 |Implement cowsay#503HilolaRustam wants to merge 8 commits into
Conversation
HilolaRustam
added
📅 Sprint 4
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Part of your implementation may be missing, can you check?
There was a problem hiding this comment.
Is this file missing something?
LonMcGregor
added
Reviewed
HilolaRustam
added
Needs Review
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Almost there! Good work
There was a problem hiding this comment.
It looks like this file is still empty. If you're using a 3rd party package,it should be listed here
There was a problem hiding this comment.
Thanks, I've added cowsay to requirements.txt so the dependency is properly declared.
|
|
||
| animal = args.animal or "cow" | ||
|
|
||
| print(getattr(cowsay, animal)(message)) |
There was a problem hiding this comment.
Do you need this print() here?
There was a problem hiding this comment.
Yes, cowsay returns a string rather than printing directly, so print() is needed. I’ll refactor it slightly for readability by separating the function call from the print statement.
LonMcGregor
added
Reviewed
HilolaRustam
added
Needs Review
2 participants
Learners, PR Template
Self checklist
Changelist
Implement cowsay exercise is completed.
Questions