Skip to content

Render upper_bound parameter contracts in the paper - #1246

Open
isPANN wants to merge 1 commit into
mainfrom
fix/paper-upper-bound-contract
Open

isPANN wants to merge 1 commit into
mainfrom
fix/paper-upper-bound-contract

Conversation

@isPANN

@isPANN isPANN commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • format-parameter-contract in docs/paper/reductions.typ matched "bound-only", but the graph export (src/rules/graph.rs) emits "upper_bound". Every upper-bound formula therefore rendered as field unavailable: for all rules.
  • Now matches upper_bound (field <= formula) and unavailable explicitly, and panics on any unknown contract so a future rename fails the build instead of mislabelling silently.

Verification

make paper builds; the PDF now shows 498 <= contracts and only 1 genuine unavailable:.

🤖 Generated with Claude Code

The paper renderer matched "bound-only", but the graph export emits
"upper_bound", so every upper-bound formula rendered as unavailable.
Match the exported names explicitly and panic on unknown contracts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Nov 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.19%. Comparing base (e7bacb3) to head (a77d2a2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1246   +/-   ##
=======================================
  Coverage   97.19%   97.19%           
=======================================
  Files        1146     1146           
  Lines      151558   151558           
=======================================
  Hits       147308   147308           
  Misses       4250     4250           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant