Skip to content

Mcat service rel cat improvement - #619

Merged
vladd-bit merged 18 commits into
mainfrom
mcat_service_rel_cat_improvement
Sep 24, 2026
Merged

vladd-bit merged 18 commits into
mainfrom
mcat_service_rel_cat_improvement

Conversation

@vladd-bit

Copy link
Copy Markdown
Member
  • Added relations to medcat service output.
  • Added relations to medcat-v2 pipeline output.
  • Corrected cdb loading for RelCAT module
  • Added concept types to relation output
  • Added component settings to m-catservice for future use.

Draft.

@vladd-bit vladd-bit self-assigned this Sep 15, 2026
@vladd-bit
vladd-bit marked this pull request as draft September 16, 2026 20:08
@vladd-bit
vladd-bit requested a review from mart-r September 20, 2026 14:59
@vladd-bit
vladd-bit marked this pull request as ready for review September 20, 2026 15:23

@mart-r mart-r left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing for the disabled components bit to avoid using internals.

Is there a reason to have a disabled components use case? Is there a specific use case in mind? Perhaps we could move that to the core lib if that's the case? Just thinking out loud. I'll be happy with the change I proposed.

@vladd-bit

Copy link
Copy Markdown
Member Author

One minor thing for the disabled components bit to avoid using internals.

Is there a reason to have a disabled components use case? Is there a specific use case in mind? Perhaps we could move that to the core lib if that's the case? Just thinking out loud. I'll be happy with the change I proposed.

The idea would be to have something like http://host/disabled_components=rel_cat, for example, the use case here being that some people might not really want to run rel_cat over the text/annotations since it takes ages to compute without filters for just even 1 document (at lest on cpu). I still need to add an option to do relations only for example if only rel_cat is enabled and everything else is disabled in the near future, also need to change acceptable payloads.

@mart-r mart-r left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vladd-bit
vladd-bit merged commit 3d72d7a into main Sep 24, 2026
20 checks passed
@vladd-bit
vladd-bit deleted the mcat_service_rel_cat_improvement branch September 24, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants