Skip to content

chore: codeowners - #666

Merged
tomolopolis merged 3 commits into
mainfrom
chore-codeowners-first-pass
Nov 13, 2026
Merged

tomolopolis merged 3 commits into
mainfrom
chore-codeowners-first-pass

Conversation

@tomolopolis

@tomolopolis tomolopolis commented Nov 6, 2026 •

Copy link
Copy Markdown
Member
  • the cs dev team can always approve for the majority of dirs
  • for those mature projects (dirs) with more than one dev, have listed those folks alongside the team
  • primary devs for each dir also added so the review is explicitly on their queue anyway

@mart-r mart-r left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've suggested some changes.

In addition, perhaps we would want to add a workflow that makes sure all high level folders are represented in this file? So we avoid creating a new folder and not knowing who the owner is.

EDIT:
PR #666 - stay away!

Comment thread .github/CODEOWNERS Outdated
/medcat/ @mart-r @adam-sutton-1992 @vladd-bit
/medcat-den/ @CogStack/cogstack-development @mart-r
/medcat-model-distributor/ @CogStack/cogstack-development @mart-r
/medcat-plugins/ @CogStack/cogstack-development @mart-r

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a fair few plugins in there, some of which (i.e transformers NER and embedding linker) were created by Adam, so I'd add him here as welll.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread .github/CODEOWNERS Resolved
Comment thread .github/CODEOWNERS Outdated
/.devcontainer/ @CogStack/cogstack-development
/.github/ @mart-r @tomolopolis @vladd-bit @adam-sutton-1992
/anoncat-demo-app/ @CogStack/cogstack-development
/cogstack-es/ @CogStack/cogstack-development

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can put me in here.
But I don't fully know if anyone is using this. So may need to investigate whether we want to keep it.

I think it is certainly a nice way to unify the way people interact with everything but only if / when people use it. The other issue is that this exposes only a small subset of functionality that ES or OS have.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread .github/CODEOWNERS Outdated
@@ -0,0 +1,26 @@
# Code owners for each top-level directory.
#
# Default owner is @CogStack/cogstack-development. A directory lists individual

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this overview?
Reads like the AI agent telling you what they've done rather than an instruction for someone else editing this in the future.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@mart-r mart-r left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's roll this out and make changes if/when needed.

@tomolopolis
tomolopolis merged commit 276f4f6 into main Nov 13, 2026
6 checks passed
@tomolopolis
tomolopolis deleted the chore-codeowners-first-pass branch November 13, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants