✨ Add UART receive support to Serial (TryRead/Read) - #3269
Closed
blueheron786 wants to merge 3 commits into
Closed
blueheron786 wants to merge 3 commits into
blueheron786 wants to merge 3 commits into
Conversation
Author
|
Attached is an example of how I wire this up in my project. This allows Copilot to interactively read from and write to the terminal, enabling better end-to-end testing. |
blueheron786
force-pushed
the
blueheron786/uart-receive
branch
from
October 2, 2026 00:08
a2ffde4 to
6bafda4
Compare
blueheron786
force-pushed
the
blueheron786/uart-receive
branch
from
October 2, 2026 15:58
6bafda4 to
2fd31f6
Compare
Author
|
Hi maintainers. I am quite surprised to see that this entire assembly is full of internal static classes and enums and structs. Should this change be done here, like this? Or does it make sense to relocate it to a different assembly? |
blueheron786
force-pushed
the
blueheron786/uart-receive
branch
from
October 2, 2026 21:23
2fd31f6 to
2076fbd
Compare
Author
|
Took a look at the docs on public API files and this seems like the wrong thing to do. Seams are the right way to do this. Plus, the binary protocol used by the tests might work instead. Closing as no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update public‑API manifest, too.