fix: require a collection for every release (#286) - #306
Conversation
Document that releases always have a collection (empty v1 allowed), require artifacts on the collection schema, and clarify /collection/latest 404. Thanks @taleodor Signed-off-by: Mehrn0ush <mehrnoush.vaseghi@gmail.com>
taleodor
left a comment
There was a problem hiding this comment.
Two edits and this is good. (1) The component-release-with-collection example is now inconsistent with the rule: version: 2 with INITIAL_RELEASE and artifacts. Make it version: 1, or keep 2 and use ARTIFACT_ADDED. (2) In tea-collection.md, replace the quoted "version 1 is whatever was first observable" line with plain prose, e.g. "In both cases version 1 is the first collection a client could have retrieved." While in that list, the empty bullet above artifacts can go.
Also, Line 333 is a stray empty bullet ( -) between updateReason and artifacts. Pre-existing, but the list is being edited in this PR, so pls correct.
Use ARTIFACT_ADDED for the version-2 example with artifacts, replace the quoted version-1 line with plain prose, and drop the stray empty bullet. Signed-off-by: Mehrn0ush <mehrnoush.vaseghi@gmail.com>
|
Thanks. |
Summary
Test plan
Thanks @taleodor
Closes #286