Skip to content

🐛 fix bundle size increase threshold never triggering#4852

Merged
rgaignault merged 2 commits into
mainfrom
roman.gaignault/fix-bundle-size-threshold
Jul 6, 2026
Merged

🐛 fix bundle size increase threshold never triggering#4852
rgaignault merged 2 commits into
mainfrom
roman.gaignault/fix-bundle-size-threshold

Conversation

@rgaignault

Copy link
Copy Markdown
Contributor

Motivation

The bundle-size PR comment never flags a size increase. The warning was meant to fire at +5% growth but never does.

Changes

percentageChange is a ratio (0.05 = 5%), but it was compared against SIZE_INCREASE_THRESHOLD = 5, i.e. +500% — so the ⚠️ status and the "exceeds 5%" warning were effectively dead. The table itself was fine since the Δ% column is formatted separately. Set the threshold to 0.05.

Test instructions

Hard to test without a real +5% bundle bump. Reviewable by reading the diff.

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.
  • Updated documentation and/or relevant AGENTS.md file

@rgaignault rgaignault requested a review from a team as a code owner July 6, 2026 14:17

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 711a3512d8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/bundle-size/lib/bundleSizes.ts
@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 172.76 KiB 172.76 KiB 0 B 0.00%
Rum Profiler 8.22 KiB 8.22 KiB 0 B 0.00%
Rum Recorder 21.14 KiB 21.14 KiB 0 B 0.00%
Logs 55.44 KiB 55.44 KiB 0 B 0.00%
Rum Slim 130.87 KiB 130.87 KiB 0 B 0.00%
Worker 22.96 KiB 22.96 KiB 0 B 0.00%

@datadog-prod-us1-6

datadog-prod-us1-6 Bot commented Jul 6, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 77.19% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 3718675 | Docs | Datadog PR Page | Give us feedback!

@rgaignault

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 6, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-06 18:28:16 UTC ℹ️ Start processing command /merge


2026-07-06 18:28:22 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-07-06 18:29:14 UTC ⚠️ MergeQueue: This merge request was unqueued

roman.gaignault@datadoghq.com unqueued this merge request

@rgaignault

Copy link
Copy Markdown
Contributor Author

/merge -c

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 6, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-06 18:29:09 UTC ℹ️ Start processing command /merge -c

@rgaignault rgaignault merged commit 413d568 into main Jul 6, 2026
31 of 32 checks passed
@rgaignault rgaignault deleted the roman.gaignault/fix-bundle-size-threshold branch July 6, 2026 18:31
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants