🐛 fix bundle size increase threshold never triggering#4852
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 711a3512d8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Bundles Sizes Evolution
|
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 3718675 | Docs | Datadog PR Page | Give us feedback! |
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
roman.gaignault@datadoghq.com unqueued this merge request |
|
/merge -c |
|
View all feedbacks in Devflow UI.
|
Motivation
The bundle-size PR comment never flags a size increase. The warning was meant to fire at +5% growth but never does.
Changes
percentageChangeis a ratio (0.05= 5%), but it was compared againstSIZE_INCREASE_THRESHOLD = 5, i.e. +500% — so the0.05.Test instructions
Hard to test without a real +5% bundle bump. Reviewable by reading the diff.
Checklist