RUM-18325: Restore accessibility-change dedup for full ViewEvent writes - #3814
RUM-18325: Restore accessibility-change dedup for full ViewEvent writes#3814hamorillo wants to merge 1 commit into
Conversation
|
✅ All CI checks and tests passed. Datadog automation helped this PR pass. 🎉 All green!🧪 All tests passed 🔄 Datadog retried 1 test - 1 passed on retry 🎯 Code Coverage (details) 🔗 Commit SHA: 1a3a46f | Docs | View more details | Give us feedback! |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a3a46f65a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
What does this PR do?
Restores
RumViewEventFilter's batch-level dedup for fullViewEventwrites, which was unintentionally disabled whenRumDataWriter.hasAccessibilitystarted always evaluating totrue. Tracks the last-written accessibility snapshot perviewIdinRumDataWriter, sohasAccessibilitycorrectly reflects whether accessibility actually changed since the last full-view write for that specific view.Motivation
Flagged by Codex's automated review on PR #3809:
RumViewScopenow always populatesViewEvent.view.accessibility(supersededAccessibilitySnapshotManager's null-unless-changed approach with diff-level dedup forViewUpdateEvent, which works correctly). However,RumDataWriterstill computedhasAccessibility = event.view.accessibility != null, which is now alwaystrue. SinceRumViewEventFiltertreatshasAccessibility == trueas "always retain this event," dedup for redundant fullViewEvents never triggers anymore — every full view write is persisted/uploaded, even when a later document version fully supersedes it. Data volume only, not data loss (see RUM-18325 for full analysis).Additional Notes
Review checklist (to be filled by reviewers)