Delegate TrackingConsent to stub DatadogContext - #3815
Merged
Merged
Conversation
Fixes possible NPE when running tests that rely on trackingConsent being set
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
0xnm
approved these changes
Sep 2, 2026
hamorillo
approved these changes
Sep 2, 2026
jonathanmos
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes possible NPE when running tests that rely on trackingConsent being set
This is backporting part of the change enable client-side-stats in dogfooding before the reset of
dogfoodingdfcbbc0
Motivation
When client side stats gets enabled by default, it triggers a code path that reads this field which triggers a NPE in tests
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)