Skip to content

[FFL-2929] Add FFE ownership for Android Flags - #3829

Open
leoromanovsky wants to merge 1 commit into
developfrom
leoromanovsky/flags-codeowners-ffe
Open

[FFL-2929] Add FFE ownership for Android Flags#3829
leoromanovsky wants to merge 1 commit into
developfrom
leoromanovsky/flags-codeowners-ffe

Conversation

@leoromanovsky

Copy link
Copy Markdown
Contributor

Motivation

Changes to the Android Flags SDK do not request review from the FFE SDK team. Only the OpenFeature integration has explicit FFE ownership.

Changes and Decisions

  • Add the FFE SDK team as an owner of dd-sdk-android-flags.
  • Preserve the existing RUM Mobile and Android owners.

@datadog-prod-us1-4

datadog-prod-us1-4 Bot commented Sep 4, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🔄 Datadog retried 1 test - 1 passed on retry View in Datadog

🔄 Datadog auto-retried 1 job - 1 passed on retry View in Datadog

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 71.75% (+0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 8f64661 | Docs | View more details | Give us feedback!

@leoromanovsky
leoromanovsky marked this pull request as ready for review September 4, 2026 01:19
@leoromanovsky
leoromanovsky requested review from a team as code owners September 4, 2026 01:19
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-04T01:22:00.646281Z 8f64661 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8f6466174e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/CODEOWNERS

## Feature Flags

/features/dd-sdk-android-flags/ @DataDog/rum-mobile @DataDog/rum-mobile-android @DataDog/feature-flagging-and-experimentation-sdk

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve documentation ownership for the Flags README

When a PR modifies features/dd-sdk-android-flags/README.md, this later directory pattern becomes the last matching CODEOWNERS entry and overrides the existing *README.md rule, so @DataDog/documentation will no longer be requested for changes to that README. Add a README-specific entry after this rule, as already done for the OpenFeature module, that retains the documentation team alongside the new owners.

Useful? React with 👍 / 👎.

Comment thread .github/CODEOWNERS

## Feature Flags

/features/dd-sdk-android-flags/ @DataDog/rum-mobile @DataDog/rum-mobile-android @DataDog/feature-flagging-and-experimentation-sdk

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Use the required RUM commit-title format

The reviewed commit is titled [FFL-2929] Add FFE ownership for Android Flags, which does not follow the repository-required RUM-XXXXX: <short description> format. Rename the commit before merge so it complies with the project’s commit convention.

AGENTS.md reference: AGENTS.md:L127-L131

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant