fix(deps): vuln minor upgrades — 4 packages (minor: 3 · patch: 1) [package.json] - #1378
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to remediate reported dependency vulnerabilities by upgrading dd-trace and overriding several transitive dependencies via Yarn resolutions, with corresponding lockfile updates.
Changes:
- Upgraded direct dev dependency
dd-traceto^5.123.0. - Updated transitive
nanoidvia resolutions to^3.3.18. - Added resolutions intended to bump transitive
@sigstore/coreandajv(though the currentyarn.lockstill resolves older versions for these).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| package.json | Bumps dd-trace, adjusts nanoid resolution, and adds resolutions for @sigstore/core and ajv. |
| yarn.lock | Updates the dependency graph/lockfile for the bumped dependencies (with remaining older @sigstore/core / ajv resolutions present). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "@sigstore/core@npm:^3.0.0": "npm:^3.2.1", | ||
| "ajv@npm:^6.10.0": "npm:^6.15.0", | ||
| "ajv@npm:^6.12.4": "npm:^6.15.0" |
| "minimatch@^10.1.1": "10.2.3", | ||
| "lodash": "4.18.0", | ||
| "nanoid": "3.3.8", | ||
| "nanoid": "^3.3.18", |
| "@typescript-eslint/eslint-plugin": "5.61.0", | ||
| "@typescript-eslint/parser": "5.61.0", | ||
| "dd-trace": "^5.28.0", | ||
| "dd-trace": "^5.123.0", |
Auto-rebase completeBranch is up to date with Auto-Rebase · Add |
5fcc777 to
302ee05
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
Suppressed comments (1)
package.json:134
- The new Yarn resolution for
@sigstore/coredoesn’t appear to be taking effect: yarn.lock still pins "@sigstore/core@npm:^3.0.0" to version 3.0.0 (see yarn.lock:4949-4952). This means the intended security upgrade to 3.2.1 isn’t actually applied via the lockfile.
"@sigstore/core@npm:^3.0.0": "npm:^3.2.1",
| "ajv@npm:^6.10.0": "npm:^6.15.0", | ||
| "ajv@npm:^6.12.4": "npm:^6.15.0" |
cdn34dd
left a comment
There was a problem hiding this comment.
We should review the dependencies we have in the project, here dd-trace is listed as a dependency, but I don't think it's used anywhere in the project and should probably be removed.
….json] Co-authored-by: dd-octo-sts-c33ac5[bot] <256648544+dd-octo-sts-c33ac5[bot]@users.noreply.github.com>
Co-authored-by: dd-octo-sts-c33ac5[bot] <256648544+dd-octo-sts-c33ac5[bot]@users.noreply.github.com>
302ee05 to
b6774fb
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (3)
package.json:136
- The new
resolutionsentries for@sigstore/coreandajvdon't appear to be applied inyarn.lockyet (the lock still pins@sigstore/core@^3.0.0to 3.0.0 andajv@^6.xto 6.12.6). As a result, this PR likely does not actually upgrade those transitive packages or remediate the reported vulnerabilities. Please re-runyarn install(or the repo’s standard lockfile update command) and commit the updatedyarn.lock, and ensure the PR description reflects the versions that are truly locked.
"@sigstore/core@npm:^3.0.0": "npm:^3.2.1",
"ajv@npm:^6.10.0": "npm:^6.15.0",
"ajv@npm:^6.12.4": "npm:^6.15.0"
package.json:136
- In this repo’s
resolutionsblock, most overrides are pinned to exact versions. Using semver ranges here (npm:^…) makes the override non-deterministic and can allow future unreviewed changes when the lockfile is regenerated.
"@sigstore/core@npm:^3.0.0": "npm:^3.2.1",
"ajv@npm:^6.10.0": "npm:^6.15.0",
"ajv@npm:^6.12.4": "npm:^6.15.0"
package.json:107
resolutionsgenerally pins exact versions in this file (e.g.,lodash,tmp,send). Using a range fornanoidmakes the override less deterministic when regenerating the lockfile.
"nanoid": "^3.3.18",
Summary: High-severity security update — 4 packages upgraded (MINOR changes included)
Manifests changed:
package.json(yarn)✅ Action Required: Please review the changes below. If they look good, approve and merge this PR.
Updates
Security Details
🚨 Critical & High Severity (6 fixed)
ℹ️ Other Vulnerabilities (4)
$dataoptionReview Checklist
Standard review:
Update Mode: all_vulns
🤖 Generated by DataDog Automated Dependency Management System