Skip to content

debugger/symdb: add upload metadata fields to upload event message#11329

Open
andreimatei wants to merge 1 commit intomasterfrom
andrei/symdb-upload-fields
Open

debugger/symdb: add upload metadata fields to upload event message#11329
andreimatei wants to merge 1 commit intomasterfrom
andrei/symdb-upload-fields

Conversation

@andreimatei
Copy link
Copy Markdown
Contributor

Add the following fields to the SymDB upload event message that accompanies each multipart upload:

  • "version" (top-level): the service version
  • "language" (top-level): "java"
  • "upload_id" (top-level): a UUID generated once per SymbolSink instance, shared by all batches uploaded by the sink
  • "batch_num" (top-level): 1-indexed counter incremented per upload
  • "final" (top-level): always false; the Java tracer continuously uploads new code as classes get loaded, so there is no defined end-of-upload point
  • "attachment_size" (top-level): size in bytes of the (compressed) attachment payload

Some of these fields are new, to be used by the backend in the future. Others duplicate info that was already included in the attachment; by duplicating some metadata out of the SymDB attachment body into the EvP event body, the backend can populate per-attachment bookkeeping without downloading the attachment.

@andreimatei andreimatei requested a review from a team as a code owner May 8, 2026 17:40
@andreimatei andreimatei requested review from jpbempel and removed request for a team May 8, 2026 17:40
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a82745bb27

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Add the following fields to the SymDB upload event message that
accompanies each multipart upload:

- "version" (top-level): the service version
- "language" (top-level): "java"
- "upload_id" (top-level): a UUID generated once per SymbolSink
  instance, shared by all batches uploaded by the sink
- "batch_num" (top-level): 1-indexed counter incremented per upload
- "final" (top-level): always false; the Java tracer continuously
  uploads new code as classes get loaded, so there is no defined
  end-of-upload point
- "attachment_size" (top-level): size in bytes of the (compressed)
  attachment payload

Some of these fields are new, to be used by the backend in the future.
Others duplicate info that was already included in the attachment; by
duplicating some metadata out of the SymDB attachment body into the EvP
event body, the backend can populate per-attachment bookkeeping without
downloading the attachment.
@andreimatei andreimatei force-pushed the andrei/symdb-upload-fields branch from a82745b to 37aee89 Compare May 8, 2026 17:46
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented May 8, 2026

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1778262954 1778263300
end_time 2026-05-08T17:57:19 2026-05-08T18:03:06
git_branch master andrei/symdb-upload-fields
git_commit_sha be0f519 37aee89
start_time 2026-05-08T17:55:54 2026-05-08T18:01:41
See matching parameters
Baseline Candidate
ci_job_id 1668778267 1668778267
ci_pipeline_id 112230928 112230928
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1778262347 1778262347

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics.

See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-64.720µs; +28.032µs] or [-21.026%; +9.107%]
unstable
[-81.993µs; +34.935µs] or [-23.081%; +9.834%]
unstable
[-95.799µs; +40.986µs] or [-25.625%; +10.963%]
unstable
[-381.093µs; +450.927µs] or [-27.433%; +32.460%]
same
scenario:basic same same same unstable
[+218.947µs; +476.854µs] or [+21.724%; +47.313%]
unstable
[-142.849op/s; +142.849op/s] or [-5.714%; +5.714%]
scenario:loop unsure
[-7.832µs; -0.200µs] or [-0.088%; -0.002%]
unsure
[-16.496µs; -2.131µs] or [-0.184%; -0.024%]
unsure
[-12.725µs; -0.552µs] or [-0.140%; -0.006%]
same same
Request duration reports for reports
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (355.238 µs) : 281, 429
.   : milestone, 355,
basic (295.71 µs) : 287, 305
.   : milestone, 296,
loop (8.976 ms) : 8969, 8984
.   : milestone, 8976,
section candidate
noprobe (331.709 µs) : 305, 358
.   : milestone, 332,
basic (293.636 µs) : 287, 300
.   : milestone, 294,
loop (8.967 ms) : 8961, 8973
.   : milestone, 8967,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 355.238 µs [281.156 µs, 429.32 µs]
basic 295.71 µs [286.89 µs, 304.531 µs]
loop 8.976 ms [8.969 ms, 8.984 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 331.709 µs [305.451 µs, 357.967 µs]
basic 293.636 µs [287.104 µs, 300.168 µs]
loop 8.967 ms [8.961 ms, 8.973 ms]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant