debugger/symdb: add upload metadata fields to upload event message#11329
Open
andreimatei wants to merge 1 commit intomasterfrom
Open
debugger/symdb: add upload metadata fields to upload event message#11329andreimatei wants to merge 1 commit intomasterfrom
andreimatei wants to merge 1 commit intomasterfrom
Conversation
Contributor
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a82745bb27
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Add the following fields to the SymDB upload event message that accompanies each multipart upload: - "version" (top-level): the service version - "language" (top-level): "java" - "upload_id" (top-level): a UUID generated once per SymbolSink instance, shared by all batches uploaded by the sink - "batch_num" (top-level): 1-indexed counter incremented per upload - "final" (top-level): always false; the Java tracer continuously uploads new code as classes get loaded, so there is no defined end-of-upload point - "attachment_size" (top-level): size in bytes of the (compressed) attachment payload Some of these fields are new, to be used by the backend in the future. Others duplicate info that was already included in the attachment; by duplicating some metadata out of the SymDB attachment body into the EvP event body, the backend can populate per-attachment bookkeeping without downloading the attachment.
a82745b to
37aee89
Compare
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (355.238 µs) : 281, 429
. : milestone, 355,
basic (295.71 µs) : 287, 305
. : milestone, 296,
loop (8.976 ms) : 8969, 8984
. : milestone, 8976,
section candidate
noprobe (331.709 µs) : 305, 358
. : milestone, 332,
basic (293.636 µs) : 287, 300
. : milestone, 294,
loop (8.967 ms) : 8961, 8973
. : milestone, 8967,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the following fields to the SymDB upload event message that accompanies each multipart upload:
Some of these fields are new, to be used by the backend in the future. Others duplicate info that was already included in the attachment; by duplicating some metadata out of the SymDB attachment body into the EvP event body, the backend can populate per-attachment bookkeeping without downloading the attachment.