👷 consolidate safe Renovate updates - #187
Merged
Merged
Conversation
Folds the two mergeable Renovate PRs into one change and stops the two unmergeable ones from being reproposed every weekend. Dependencies (#162): all non-major bumps. Lockfiles were regenerated against current main rather than reusing Renovate's stale artifacts, which also keeps playground/yarn.lock and e2e/app/yarn.lock in sync — both consume the SDK via `portal:`, so a root dependency change invalidates them and CI's immutable install fails otherwise (the actual cause of the red CI on #171). dd-trace 5.109.0 -> 5.115.0 is the only production dependency here. Formatting: prettier 3.9 collapses union types and empty object types that previously wrapped. Pure `yarn format` output, no logic changes. This is what made #162 fail both `format` and `lint` — eslint.config.mjs pulls in eslint-plugin-prettier/recommended, so the drift surfaced as lint errors too. The two generated *.types.ts files are safe to reformat because scripts/generate-schema-types.ts runs `prettier --write` on its own output. CI (#184): actions/setup-node v7, superseding the v6.5.0 bump in the group. Pinned to a full commit SHA per DataDog enterprise policy. Note publish.yml only runs on workflow_dispatch, so CI never exercises this — validate with a `dry_run: true` run of the publish workflow. Renovate config, for updates that cannot be accepted today: - Cargo.lock: the existing cargo rule only matches minor/patch, so lockFileMaintenance bypassed the freeze and #165 pulled in ~40 crate bumps. No CI job builds the WASM, so those are entirely untested. - vite in electron-vite-esm: electron-vite 5.0.0 declares a peer range of ^5 || ^6 || ^7, so vite 8 (#164) cannot work there. Closes #162, closes #184, closes #164, closes #165. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
bcaudan
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates the Renovate backlog: takes the two updates that are safe today, and stops the two that aren't from being reproposed every weekend.
Open PRs handled
actions/setup-nodev7vite8electron-vite@5.0.0declares a peer range of^5 || ^6 || ^7, so vite 8 can't work in that app. Renovate now pins it to<8yarn.lockhalf couldn't be generated at all, and the rest was ~40 untested Rust crate bumps. Renovate now keepsCargo.lockout of lock file maintenanceNot touched, still open: #171 (dd-trace v6, runtime major — needs its own PR) and #123 (typescript v6, contains hand-written migration work and is superseded by TS 7).
Why #162 was red, and what changed
Two failing jobs, one cause:
prettier3.9 collapses union types and empty object types that previously wrapped.formatfailed directly, andlintfailed becauseeslint.config.mjspulls ineslint-plugin-prettier/recommended. Fixed withyarn format— 5 files, pure formatter output, no logic changes. eslint 10.7 / typescript-eslint 8.64 report nothing new beyond that.Lockfiles were regenerated against current
mainrather than reusing Renovate's stale artifacts. That also keepsplayground/yarn.lockande2e/app/yarn.lockin sync: both consume the SDK viaportal:, so any root dependency change invalidates them and CI's immutable install fails. That is the actual reason #171's CI is red — not a dd-trace v6 incompatibility.Review notes
dd-trace5.109.0 → 5.115.0 is the only production dependency in this PR. Everything else is devDeps, CI,packageManager/volta, and lockfiles.*.types.tsfiles are safe to reformat:scripts/generate-schema-types.tsrunsprettier --writeon its own output, so regeneration matches.publish.ymlonly runs onworkflow_dispatch, so CI never exercises the setup-node bump. Worth adry_run: truerun of the publish workflow before the next release.Verified locally
yarn install --immutable× 3 (root, playground, e2e/app) ·format:check·eslint --max-warnings 0·typecheck·build·check-package-content·check-licenses· unit tests (45 files, 777 tests) · e2e app + playground builds — all pass.Not run locally: the Playwright
e2e/integrationsuites (need Electron + xvfb); both were already green on #162.Known issue this does not fix
Renovate can't regenerate the root
yarn.lockat all — thebcaudan/json-schema-to-typescriptfork is blocked by yarn'sapprovedGitRepositoriesin Renovate's sandbox, so everylockFileMaintenancerun will be partial. Not fixable inrenovate.json; needs either a Renovate-side allowlist or replacing the fork with apatch:dep on the published package.🤖 Generated with Claude Code