kong: add container-based config discovery support#24318
Draft
vitkyrka wants to merge 2 commits into
Draft
Conversation
Adds a discovery strategy and auto_conf.yaml entry so the Agent can automatically discover and configure Kong containers, covering both the OpenMetrics and legacy status-endpoint modes. Environment: Datadog workspace Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Environment: Datadog workspace Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
Validation ReportAll 21 validations passed. Show details
|
Contributor
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 4f29da8 | Docs | Datadog PR Page | Give us feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds container-based config discovery support to the kong integration. When the Datadog Agent detects a container with the
kongAD identifier, it probes the container's exposed ports — starting with 8001 if it is among them — until it finds the metrics endpoint, then schedules an OpenMetrics check against it automatically — no manualconf.yamlneeded.Both the legacy and OpenMetrics modes are probed — see the two candidates in the
discovery:block.Endpoint availability: Since Kong 2.8, the Admin API exposes
/metricsnatively without requiring the Prometheus plugin to be explicitly enabled, which is why the OpenMetrics candidate works against the standard, unmodifiedkongcontainer.Motivation
Part of DSCVR-485. Follows the same pattern established by the krakend integration.
Port selection rationale: Port 8001 is Kong's default Admin API port, which exposes both the OpenMetrics
/metricsendpoint and the legacy/status/endpoint (confirmed by theKONG_ADMIN_LISTENdefault in the test environment and the integration's ownconf.yaml.exampledefault ofhttp://localhost:8001/metrics).Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged