Limit numeric token length during parsing#1030
Open
RolandK wants to merge 1 commit into
Open
Conversation
RolandK
force-pushed
the
parse_number_size_limit
branch
from
fcef41a to
92395c0
Compare
Reject overly long numeric tokens before allocating temporary number strings to avoid unbounded allocations for malformed or malicious JSON input.
RolandK
force-pushed
the
parse_number_size_limit
branch
from
92395c0 to
77e4743
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_number()copies the numeric token into a temporary null-terminated buffer before passing it tostrtod(). Currently, the token length is bounded only by the remaining input size, so unusually long numeric tokens can lead tolarge temporary allocations.
This change rejects numeric tokens longer than
CJSON_NUMBER_LENGTH_LIMITbefore allocating the temporary number string.