Skip to content

Fix for issue with NSTableView binding #653#654

Open
killev wants to merge 3 commits into
DeclarativeHub:masterfrom
killev:nstableview-bug
Open

Fix for issue with NSTableView binding #653#654
killev wants to merge 3 commits into
DeclarativeHub:masterfrom
killev:nstableview-bug

Conversation

@killev

@killev killev commented Aug 5, 2019

Copy link
Copy Markdown
Contributor

Add testing target for MacOS.
Implement test for NSTableView + SignalProtocol + diff()
Fix issue with excessive reloadData in NSTableView + SignalProtocol + diff()

Implement test for NSTableView + SignalProtocol + diff()
Fix issue with excessive reloadData in NSTableView + SignalProtocol + diff()
@killev killev changed the title Fix for issue with NSTableView binding ( #653) Fix for issue with NSTableView binding #653 Aug 5, 2019
@codecov-io

codecov-io commented Aug 5, 2019

Copy link
Copy Markdown

Codecov Report

Merging #654 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #654   +/-   ##
=======================================
  Coverage   64.71%   64.71%           
=======================================
  Files          88       88           
  Lines        3877     3877           
=======================================
  Hits         2509     2509           
  Misses       1368     1368
Impacted Files Coverage Δ
...ervable Collections/Signal+ChangesetProtocol.swift 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d21d089...9264178. Read the comment docs.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.71%. Comparing base (1c4ce95) to head (9264178).
⚠️ Report is 54 commits behind head on master.

Files with missing lines Patch % Lines
...ervable Collections/Signal+ChangesetProtocol.swift 0.00% 2 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #654      +/-   ##
==========================================
- Coverage   64.88%   64.71%   -0.17%     
==========================================
  Files          88       88              
  Lines        3867     3877      +10     
==========================================
  Hits         2509     2509              
- Misses       1358     1368      +10     
Files with missing lines Coverage Δ
...ervable Collections/Signal+ChangesetProtocol.swift 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c4ce95...9264178. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants