Skip to content

chore(deps): bump django from 5.2.17 to 6.1.2 - #16354

Open
dependabot[bot] wants to merge 1 commit into
devfrom
dependabot/pip/dev/django-6.1.2
Open

dependabot[bot] wants to merge 1 commit into
devfrom
dependabot/pip/dev/django-6.1.2

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Bumps django from 5.2.17 to 6.1.2.

Commits

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Oct 14, 2026
@dependabot
dependabot Bot force-pushed the dependabot/pip/dev/django-6.1.2 branch from b8ee6d3 to 0eee88f Compare October 15, 2026 17:43

@Maffooch Maffooch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adversarial review: chore(deps): bump django from 5.2.17 to 6.1.2

Verdict: request-changes
Reviewed at: 0eee88f Profile: dependency-bump
Repo rules followed: origin/dev .claude/skills/review-pr/SKILL.md and .claude/skills/defectdojo-dev/SKILL.md, plus the generic review-pr skill

Attempts to break it

  1. Required CI on the head SHA. Build Docker Images (django, alpine, linux/amd64) failed in run 38779704628 with ResolutionImpossible, so Unit Tests Complete (required) is red and no test job ran (test-rest-framework, test-user-interface, test-k8s, test-performance all SKIPPED). Base is green: merge-group runs 38977320550 and 38974364031 on dev succeeded. Blocker.
  2. Reproduced the resolver failure locally with uv pip compile --python-version 3.14 on the Django-family pins. origin/dev resolves. The PR head fails with: django-prometheus==2.5.0 requires django>=5.1,<6.1, and you require django==6.1.2. Blocker.
  3. Is there a django-prometheus release that allows 6.1? PyPI shows 2.5.0 is the latest, and its requires_dist is still Django!=5.0.*,<6.1,>=4.2. No upgrade path exists today. django-prometheus is wired into INSTALLED_APPS, middleware and the DB engine wrapper (dojo/settings/settings.dist.py:1139-1146) and dojo/urls.py:277, so it cannot just be dropped. Blocker (upstream).
  4. Removed the django-prometheus pin and re-ran the full requirements.txt resolve for linux/py3.14. It resolves to django==6.1.2, so prometheus is the only hard install blocker. Several other pins resolve but do not advertise Django 6.x support in their PyPI classifiers: django-auditlog 3.2.1 (latest 3.4.1, classifiers stop at 5.2), django_celery_results 2.6.0, django-extensions 4.1, django-crum 0.7.9, django-single-session 0.2.0, plus django-imagekit, django-watson and django-ratelimit with no classifiers. Runtime risk, untested. No break proven; follow-up risk.
  5. Hands-on import under 6.1.2: built a venv with the resolved set plus django-prometheus==2.5.0 --no-deps, ran manage.py check and manage.py makemigrations --check --dry-run. Both pass ("No changes detected"); DEFAULT_AUTO_FIELD is pinned to AutoField at dojo/settings/settings.dist.py:478, so the 6.0 default change causes no drift. Django 6.1 emits RemovedInDjango2028Warning for every EMAIL_* setting (migrate to MAILERS). No break.
  6. Call sites of APIs removed in 6.0: grepped for format_html without args, ArrayAgg/StringAgg ordering=, CheckConstraint(check=, assertQuerysetEqual, get_joining_columns, positional save() flags. No hits. FORMS_URLFIELD_ASSUME_HTTPS = True at dojo/settings/settings.dist.py:2308 is now an inert removed setting (6.0 defaults to https anyway). No break; nit.
  7. Diff scope and security direction. The diff is one line, requirements.txt:24, as claimed. The CVEs listed in the PR body (CVE-2026-77050, -84429, -87890, -87975) are also fixed in Django 5.2.18 (release notes docs/releases/5.2.18.txt, published 2026-10-06), so the security fixes do not require the major bump. No break.

Blocking

  • requirements.txt:23-24 Django==6.1.2 is unsatisfiable with django-prometheus==2.5.0 (<6.1), the latest release. The Docker build fails and required Unit Tests Complete is red because of this PR.

Nice to have

  • Take the CVE fixes now via Django 5.2.18 (separate PR), and close or hold this one until django-prometheus ships a release that allows 6.1.
  • When the major bump is retried: remove FORMS_URLFIELD_ASSUME_HTTPS and its warning filter (dojo/settings/settings.dist.py:2302-2308), plan the EMAIL_* to MAILERS migration, and confirm 6.x support for django-auditlog, django_celery_results, django-extensions, django-crum and django-single-session.
  • Consider a Dependabot ignore for Django major versions until the plugin set catches up, so this PR does not keep reopening.

Verified hands-on

  • Resolver failure reproduced locally (uv, py3.14) on the PR head; base resolves.
  • manage.py check and makemigrations --check --dry-run under Django 6.1.2 (prometheus forced with --no-deps).

Checked only statically

  • PyPI metadata for every Django-family pin; grep for 6.0-removed APIs.

Still needs verification

  • Full unit suite, REST framework tests, spectacular --fail-on-warn and UI tests under Django 6.x. CI never ran them and I did not run them, since the image cannot be built from this requirements.txt.

@dependabot
dependabot Bot force-pushed the dependabot/pip/dev/django-6.1.2 branch 2 times, most recently from 21721b2 to 7dbe580 Compare October 21, 2026 23:17
Bumps [django](https://github.com/django/django) from 5.2.17 to 6.1.2.
- [Commits](django/django@5.2.17...6.1.2)

---
updated-dependencies:
- dependency-name: django
  dependency-version: 6.1.2
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/pip/dev/django-6.1.2 branch from 7dbe580 to 91f528d Compare October 21, 2026 23:29

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant