Skip to content

Remove backported boost patch - #605

Closed
esahin90 wants to merge 1 commit into
DeterminateSystems:mainfrom
esahin90:maint/sahin/remove-already-integrated-boost-patch
Closed

Remove backported boost patch#605
esahin90 wants to merge 1 commit into
DeterminateSystems:mainfrom
esahin90:maint/sahin/remove-already-integrated-boost-patch

Conversation

@esahin90

@esahin90 esahin90 commented Aug 25, 2026

Copy link
Copy Markdown

Motivation

Patch is already backported to 26.05 in nix-pkgs and boost will not build with this patch with newer versions of nixpkgs.

Context

See backport commit in nixpkgs
NixOS/nixpkgs@b5e0443

Summary by CodeRabbit

  • Bug Fixes

    • Improved exception tracking during Boost fiber switching, including forced-unwind scenarios.
    • Added coverage for this behavior to help ensure consistent runtime results.
  • Chores

    • Updated the Boost packaging configuration and bundled packaging materials.

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 79b9e591-939e-44a7-9b7e-d86e55c89a12

📥 Commits

Reviewing files that changed from the base of the PR and between 78dd24c and 13eb84c.

📒 Files selected for processing (2)
  • packaging/dependencies.nix
  • packaging/patches/0001-Fix-uncaught_exceptions-not-accounting-for-forced_un.patch
💤 Files with no reviewable changes (2)
  • packaging/dependencies.nix
  • packaging/patches/0001-Fix-uncaught_exceptions-not-accounting-for-forced_un.patch

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The Boost Nix override no longer applies the 0001-Fix-uncaught_exceptions-not-accounting-for-forced_un.patch patch. The patch file adds forced-unwind exception tracking and a corresponding fiber test.

Changes

Cohort / File(s) Summary
Boost patch packaging
packaging/dependencies.nix, packaging/patches/0001-Fix-uncaught_exceptions-not-accounting-for-forced_un.patch
Removes the patch from the Boost override and adds Boost.Context changes that update std::uncaught_exceptions() during forced fiber unwinds, with test coverage.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 13eb8

This PR removes an already-integrated Boost patch and its packaging reference; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing the backported Boost patch.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@edolstra

Copy link
Copy Markdown
Collaborator

Thanks, I've included this in #607 (which also updates out nixpkgs flake inputs).

@edolstra edolstra closed this Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants