LIMS-2205: Allow incoming EU shipments to be booked via the shipping service#1077
Conversation
|
Not sure if these are intended, but if you create a shipment with a contact in the UK, then switch it to an international contact, it allows the creation of multiple dewars still It also displays a message at the top if I change my lab contact afterwards |
Ah yes, good spot, it was using the old lab contact country if it got changed. Hopefully now fixed. |
|
It breaks on localhost because the shipping service currently has a bug that throws an exception if it cannot make callbacks, but I mentioned it to Matt and he's created a ticket for it All else looks good, though, so I'll approve it! |
JIRA ticket: LIMS-2205
Summary:
EU academic users should be able to use the shipping service for incoming dewars, albeit that it will just email James H and request him to make the booking. This should be behind a feature flag as we don't want to turn it on just yet.
Changes:
To test:
Go to an mx proposal, create a lab contact with an EU address
Go to /shipments/add, and start creating a shipment. Choose UDC for the scheduling option as it doesn't ask any more questions.
Select 2 dewars, choose the EU lab contact, then click "Use Facility Account", check a message appears saying you can only have 1 dewar, and the no of dewars box is now fixed at 1
Click "Add Shipment", you should be taken to the View Shipment page, check the message says you can now request your shipment, and the "Request DHL Air Waybill" button is active
Click "Request DHL Air Waybill", tick the box for the dewar, and click Proceed. Check you are taken to the (test) shipping service
Fill in your address, choosing the same EU country, and a valid postcode and EORI number. Skip the collection required step, this will be removed (ULIMS-1350), click Submit, and then Done.
You should be taken back to Synchweb, check the dewar status is 'awb requested'
In a new tab visit https://sample-shipping-test.diamond.ac.uk/shipment-requests/ and check your shipment appears at the top as "Pending" for the incoming shipment
ask Mark if he got an email asking to book the shipment, and if he can add a tracking number (2815193780 might work), the dewar status should update to "awb created", and the shipping service should describe it as "Booked"
Back in Synchweb, request the dewar to come home by pressing "Dispatch", and then "Proceed", and go through the shipping service again
Check the dewar status is back to "awb requested"
Look again at https://sample-shipping-test.diamond.ac.uk/shipment-requests, check your shipment now has Booked and Pending for incoming and outgoing, but on the same shipment request id
Set the config to have