Skip to content

Made suggested changes - #6

Open
Oli-Jones475 wants to merge 82 commits into
masterfrom
clean-up
Open

Made suggested changes#6
Oli-Jones475 wants to merge 82 commits into
masterfrom
clean-up

Conversation

@Oli-Jones475

@Oli-Jones475 Oli-Jones475 commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

After review of code the following changes have been made:

  • ReadMe updated to reference GitHub project instead of GitLab
  • PV names updated in ReadMe
  • All mentions of TelNet connections replaced with raw IP socket connections
  • Apart from receiving initial TelNet connection message which is named as such
  • Disconnect and reconnect methods added to SpecTel
  • Device trys restarting connection when the connection is broken
  • Class variables have been removed

@Oli-Jones475
Update README
ba1789f
@Oli-Jones475
Update source in README
3dc063f
@Oli-Jones475
Replace TelNet mention with socket
3749060
@Oli-Jones475
Make TelNet startup message a constant
55d448c 
Add comment about connection style (NOT TelNet)
@Oli-Jones475
Add disconnect method to spec_tel
3047894
@Oli-Jones475
Add disconnect method to controller
0ee556d
@Oli-Jones475
Replace manual disconnect methods in tests
c5c8c92
@Oli-Jones475
Fix SpecTel disconnect method
9af17bf
@Oli-Jones475
Add restart connection method
6cef421
@Oli-Jones475
Try restarting connection when message fails
df64516
@Oli-Jones475
Test connection failing
2497682
@Oli-Jones475
Replace class variables in SpecTel
479089f
@Oli-Jones475
Replace class variables in file_builder
bdd1a0c
@Oli-Jones475
Move common flame controller tests to common.py
db4f7a5
@Oli-Jones475
Clean controller_and_mock_objects arguments
fb2e9d2
@Oli-Jones475
Add note about context managers to test_common
bd8eba6
@Oli-Jones475
Move loguru_caplog to conftest
18c978b
@Oli-Jones475
Create file for testing integration time
96e3e1a
@Oli-Jones475
Add test file for scan data
533a226
@Oli-Jones475
Add file for testing captures
7bcd63d
@Oli-Jones475
Remove import notes
7c54926
@Oli-Jones475
Add connection tests to common
810e11f
@Oli-Jones475
Remove large flame_controller_test
ee434f9
@Oli-Jones475
Remove loguru caplog redundant definition
b659ab4
@Oli-Jones475
Start test_common
71ad95c
@Oli-Jones475
Setup pipe in spec tel tests
8895a91
@Oli-Jones475
Test start connection
96138b3
@Oli-Jones475
Make disconnect method for dummy_spectrometer
40b1725
@Oli-Jones475
Make startup message constant
438b637
@Oli-Jones475
Add ephemeral process to dummy_spectrometer
43f31b0
@Oli-Jones475
Create context manager for mock socket
331967f
@Oli-Jones475
Add tests for getting integration time
8312fd4
@Oli-Jones475
Add tests for setting integration time
c1121f7
@Oli-Jones475
Move test_list_equal to common file
d051587
@Oli-Jones475
Fix scan str method
5a73f15
@Oli-Jones475
Add tests for scan data
34e2276
@Oli-Jones475
Change scan error handling
c5f8175
@Oli-Jones475
Add tests for the message queue
e45e49d
@Oli-Jones475
Fix bug in bad connection
c2ce520
@Oli-Jones475
Fix bug in starting disconnect listen task
889d523
@Oli-Jones475
Change unexpected initial message to a warning
bd0b9d2
@Oli-Jones475
Cancel disconnect task when disconnecting
41cf28b
@Oli-Jones475
Close socket in generic case where connection fails
ad921ae
@Oli-Jones475
Change error to warning in bad connection message
9b56269
@Oli-Jones475
Test disconnect during scan
6c352a8
@Oli-Jones475
Test disconnect with message queue
574a8ad
@Oli-Jones475
Delete old spec tel test file
d8a0378
@Oli-Jones475
Add docstrings to test_common
b9cd05c
@Oli-Jones475
Add comments and docstrings to test_connection
48b9724
@Oli-Jones475
Add docstrings to test_integration_time
d52ec73
@Oli-Jones475
Add docstrings to test_message_queue
58f4d63
@Oli-Jones475
Add docstrings to test_scan_data
3fc0b2d
@Oli-Jones475
Give spec tel files unique names
b281875
@Oli-Jones475
Fix import paths in test files
1ed4b28
@Oli-Jones475
Add docstrings to test_integration_time
cc87228
@Oli-Jones475
Add docstrings to test_scan_data
e407819
@Oli-Jones475
Add docstrings to spectrometer_telecommunicator
0dbca71
@Oli-Jones475
Remove dummy attributes
bf93383
@Oli-Jones475
Rename controller test classes to fit standards
59667ee
@Oli-Jones475
Fix test path
68bb691
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Oli-Jones475