Fix optional plugin download logic - #893
Merged
Merged
Conversation
…s for a given instrument
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #893 +/- ##
==========================================
+ Coverage 54.99% 55.05% +0.06%
==========================================
Files 103 103
Lines 11523 11528 +5
Branches 1531 1531
==========================================
+ Hits 6337 6347 +10
+ Misses 4843 4838 -5
Partials 343 343 🚀 New features to boost your workflow:
|
stephen-riggs
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
get_plugin_wheelAPI endpoint previously did not generate the file with the correct name. This was due to a missing f-string in the"Content-Disposition"value in the header.Additionally, a new API endpoint was added that returns a HTML page showing the plugins available for a given instrument.
Tests have also been added for these two functions as part of ongoing efforts to improve test coverage for this code base.