Skip to content

Updated cryo-SIM processing logic - #896

Merged
tieneupin merged 3 commits into
mainfrom
cryo-sim-fix
Sep 22, 2026
Merged

tieneupin merged 3 commits into
mainfrom
cryo-sim-fix

Conversation

@tieneupin

@tieneupin tieneupin commented Sep 22, 2026

Copy link
Copy Markdown
Contributor
  • Simplify the pattern matching logic used to identify cryo-SIM contexts and to trigger processing.
    • When establishing the cryo-SIM workflow, it was understood that only files with stems ending in "_BR_FL", "_BFR_FL", "_GR_FL", or "_GFR_FL" would require processing. However, it turns out that this is very much not the case: A single colour channel could be collected, and users would end the file with "{color}_again_FL" if this was a repeat of a previous collection.
    • Given that we provide the OTF files for all the wavelengths to the PySIMRecon processing service, and that PySIMRecon is able to parse the file metadata to determine the colour channels to use, we don't need to look for specific colour combinations anymore, and can just trigger processing on files ending with "_FL" instead.
  • Move OTF file lookup logic into a cached function.
    • Unless a new OTF directory is uploaded during the visit, all PySIMRecon processing requests will be carried out using the same OTF files.
    • Performing this file lookup anew for every new raw data file is thus needless computational expense, and having this logic moved out into a cached function should optimise for computation.

@tieneupin tieneupin self-assigned this Sep 22, 2026
@tieneupin tieneupin added bug Something isn't working enhancement New feature or request server Relates to the server component client Relates to the client component cryo-sim Part of the cryo-SIM pipeline extension labels Sep 22, 2026
@codecov

codecov Bot commented Sep 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.07%. Comparing base (3d72386) to head (23b206f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #896      +/-   ##
==========================================
+ Coverage   55.05%   55.07%   +0.01%     
==========================================
  Files         103      103              
  Lines       11529    11534       +5     
  Branches     1531     1531              
==========================================
+ Hits         6347     6352       +5     
  Misses       4839     4839              
  Partials      343      343              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stephen-riggs stephen-riggs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look sensible to me

@tieneupin
tieneupin merged commit 27c383e into main Sep 22, 2026
14 checks passed
@tieneupin
tieneupin deleted the cryo-sim-fix branch September 22, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working client Relates to the client component cryo-sim Part of the cryo-SIM pipeline extension enhancement New feature or request server Relates to the server component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants