Repository navigation
[SC-71] contrib's coverage floor (35%) lags far behind the other three enforced crates #1342
Description
Overview
contracts/scripts/check-coverage.sh sets per-crate floors of assetsup: 70, contrib: 35, multisig-wallet: 90, asset-maintenance: 70 — contrib sits meaningfully lower than every other enforced crate. Once [SC-57] resolves the uncompiled-file question (which changes what "100% of contrib" even means) and [SC-70] adds insurance/lease coverage, the crate's real coverage should be re-measured and the floor ratcheted up to be in line with its siblings, per the script's own stated policy ("Ratchet these upward as coverage improves; never lower one without saying why").
Tasks
- After [SC-57] and [SC-70] land, re-run
cargo llvm-covforcontriband raisecrate_floor()'scontribcase to just below the newly-measured value, matching the pattern used for the other three crates. - Update the "Measured at time of writing" comment block with the new number.
Acceptance Criteria
- contrib's coverage floor is back in line with the workspace's other enforced crates, with an accurate "measured at" comment.
Dependencies
Depends on [SC-57] and [SC-70].
Notes for Contributors
Requires Rust + Soroban. Workspace: contracts/ (soroban-sdk 23, members: assetsup, contrib, multisig-wallet, multisig-transfer, asset-maintenance). Run cargo test --all, cargo fmt --all -- --check, and cargo clippy --all-targets --all-features -- -D warnings before opening a PR — CI enforces all three. Comment below to be assigned.
Activity
eliJah790 commentedon Aug 24, 2026
@eliJah790 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @eliJah790 to this issue.
nlstylz commentedon Aug 24, 2026
@nlstylz has applied to work on this issue as part of the Stellar Wave Program's 8th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @nlstylz to this issue.
omoniyiadebayo12goal-crypto commentedon Sep 24, 2026
@omoniyiadebayo12goal-crypto has applied to work on this issue as part of the Stellar Wave Program's 9th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @omoniyiadebayo12goal-crypto to this issue.
kike-alt commentedon Sep 24, 2026
@kike-alt has applied to work on this issue as part of the Stellar Wave Program's 9th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @kike-alt to this issue.
drips-wave commentedon Sep 24, 2026
Congratulations, @kike-alt! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on September 30, 2026.
🧑💻 @kike-alt: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.
Warning
When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.
🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.
🌊 Happy Wave 🌊
drips-wave commentedon Sep 24, 2026
This issue has been completed by @kike-alt as part of the Stellar Wave Program's 9th Wave 🥳
😎 @kike-alt: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.
🧑💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.