[SC-72] multisig-transfer's approval-rule configuration needs edge-case tests

[yusuftomilola]

Overview

configure_approval_rule and create_transfer_request (contracts/multisig-transfer/src/lib.rs) — worth dedicated tests for configuring a rule that requires zero approvers (should presumably be rejected as meaningless), reconfiguring an existing rule while a transfer request under the old rule is still pending, and creating a request for a category with no configured rule at all.

Tasks

• Add a test asserting configure_approval_rule rejects a zero-required-approvers configuration.
• Add a test creating a request for an asset category that has no configured approval rule, and confirm the resulting behavior (reject, or fall back to some default) is intentional and covered.
• Add a test reconfiguring a rule while a request under the previous rule is still pending, confirming the pending request's required-approvals count doesn't silently change underneath it.

Acceptance Criteria

• Zero-approver configuration, missing-rule requests, and mid-flight reconfiguration are all explicitly tested.

Notes for Contributors

Requires Rust + Soroban. Workspace: contracts/ (soroban-sdk 23, members: assetsup, contrib, multisig-wallet, multisig-transfer, asset-maintenance). Run cargo test --all, cargo fmt --all -- --check, and cargo clippy --all-targets --all-features -- -D warnings before opening a PR — CI enforces all three. Comment below to be assigned.

[onakijames-droid]

@onakijames-droid has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hi maintainer... I'll work on this issue and submit a PR for it ASAP

ℹ️ Repo Maintainers: To accept this application, review their application or assign @onakijames-droid to this issue.

[Emmyranky]

@Emmyranky has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Can I work on this issue

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Emmyranky to this issue.

[Tekh134]

@Tekh134 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hey maintainer! Good to be back
I’ve contributed here before with merged PRs
Can I take up issue ? please assign me. thank you .

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Tekh134 to this issue.

[kike-alt]

@kike-alt has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

Hi there, I'd like to contribute to this.

This touches Soroban and Rust, which I have hands-on experience with. I'll add focused test coverage for this, following the existing test patterns already used in the repo.

Please assign this issue to me, I'd be happy to contribute.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @kike-alt to this issue.

[josephinejose-alt]

@josephinejose-alt has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

studied the task at hand and i can say i have a clear understanding
pls assign me so i can begin implementation

ℹ️ Repo Maintainers: To accept this application, review their application or assign @josephinejose-alt to this issue.

[drips-wave]

Congratulations, @kike-alt! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on September 30, 2026.

🧑‍💻 @kike-alt: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[drips-wave]

This issue has been completed by @kike-alt as part of the Stellar Wave Program's 9th Wave 🥳

😎 @kike-alt: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.