Skip to content

test: add unit tests for format_stacktrace - #32

Closed
Dor-bl wants to merge 4 commits into
masterfrom
test/errorhandler-format-stacktrace-10591034586650679769
Closed

Dor-bl wants to merge 4 commits into
masterfrom
test/errorhandler-format-stacktrace-10591034586650679769

Conversation

@Dor-bl

@Dor-bl Dor-bl commented Oct 19, 2026

Copy link
Copy Markdown
Owner

Added comprehensive unit tests for format_stacktrace in appium/webdriver/errorhandler.py.

🎯 What

Addressed missing test coverage for format_stacktrace helper function in errorhandler.py.

📊 Coverage

The new tests in test/unit/webdriver/errorhandler_test.py cover:

  • Empty and falsy inputs (None, "", [], {})
  • String stack trace splitting
  • Sequence of frame dicts (handling optional lineNumber, fileName, methodName, and className)
  • Sequence containing non-dict elements
  • Non-iterable inputs triggering TypeError handling

✨ Result

100% test coverage for format_stacktrace.


PR created automatically by Jules for task 10591034586650679769 started by @Dor-bl

Add unit tests for `format_stacktrace` in `test/unit/webdriver/errorhandler_test.py` covering empty inputs, string stack traces, sequence of frame dicts with optional keys, non-dict elements, and non-iterable inputs.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Add unit tests for `format_stacktrace` in `test/unit/webdriver/errorhandler_test.py` covering empty inputs, string stack traces, sequence of frame dicts with optional keys, non-dict elements, and non-iterable inputs.
Add unit tests for `format_stacktrace` in `test/unit/webdriver/errorhandler_test.py` covering empty inputs, string stack traces, sequence of frame dicts with optional keys, non-dict elements, and non-iterable inputs.
Add unit tests for `format_stacktrace` in `test/unit/webdriver/errorhandler_test.py` covering empty inputs, string stack traces, sequence of frame dicts with optional keys, non-dict elements, and non-iterable inputs.

Dor-bl commented Oct 19, 2026

Copy link
Copy Markdown
Owner Author

Closing: duplicate of #17 (same pattern as #18, #20, #27 and #30 before it). This PR also creates a brand-new test/unit/webdriver/errorhandler_test.py covering format_stacktrace, which conflicts outright with #17, already open and covering the same function. Nothing here is worth mirroring upstream separately from #17.


Generated by Claude Code

@Dor-bl Dor-bl closed this Oct 19, 2026
@google-labs-jules

Copy link
Copy Markdown

Closing: duplicate of #17 (same pattern as #18, #20, #27 and #30 before it). This PR also creates a brand-new test/unit/webdriver/errorhandler_test.py covering format_stacktrace, which conflicts outright with #17, already open and covering the same function. Nothing here is worth mirroring upstream separately from #17.


Generated by Claude Code

Understood. Acknowledging that this PR is a duplicate and stopping work on this task.

@Dor-bl
Dor-bl deleted the test/errorhandler-format-stacktrace-10591034586650679769 branch October 20, 2026 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant