Repository navigation
fix(acceptance): correct TI03, TI04 and RG07, follow titiler-eopf to v0.12.4 - #14
Merged
Merged
Conversation
…tells a flat patch from a constant render The item route's tilejson says 0-24, so z0 and z24 tested nothing, and a saturated cloud at the centre of a scene failed as a constant render.
obstore reports the epoch for a missing header, so every item looked newer than its store.
/rstaging runs it. The reader code is unchanged since v0.12.2; the regenerated constraints bring its dependency updates.
…30 Nov The review date passed on 31 Oct and the >0.12 flip isn't ready yet, so the config's own rule says to extend it.
…eport what was compared A tile only clears another if it has enough valid pixels, and a tile that can't be read now fails. TI04 also takes its zoom from the store's levels.
… crashing the run The decode error stopped the run and lost the rest of the battery.
…say why store levels are missing Some bad bodies still stopped the run, and unusable store metadata brought back z0 and z24 on the item route.
lhoupert
marked this pull request as ready for review
November 4, 2026 17:34
Keeps the image's versions in the constraints, as pyproject.toml's rule says, over the bumps in main.
… the Explorer's as TI10 A cloudy scene clipped to one colour at 0,0.3, which no item link uses. The threshold moves with the stretch so dark scenes keep the same bar.
…TI10's report honest TI10 runs on one API, says which levels it couldn't judge, and always sends its stretch. Only decoding errors now read as a bad tile.
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three wrong results from the 3 Nov runs on EODC's rc stores, makes TI03 test the stretches consumers use, and renews an expired known issue.
min_distinctmoves from 16 to 5 with it, because each PNG level now covers more reflectance: 5 levels at 0,1 span 0.0196, 16 at 0,0.3 span 0.0188. A level where no tile varies still FAILs, and the message now says where the pixels sit.min_distinct10. A level flat on the tiles tried is a WARN, because a clouded scene clipping isn't a store defect, and a tile that can't be read is a FAIL. It runs only where a config setsrender.second_stretch, which today is L2A, and on one API, 0.12, because whether data clips doesn't depend on the titiler version.Last-Modified(data.eodc.eu): obstore reports the epoch, so every item looked newer than its store. It now SKIPs.readerpin and the constraints follow the version /rstaging reported on 3 Nov. Nothing undertitiler/changed since v0.12.2; the regenerated lock brings its dependency updates (rio-tiler 9.4, obstore 0.12).For reviewers:
pyproject.tomlsays: the suite runs what the image runs. Dependabot will propose them again unless its/acceptanceconfig changes.color_formula, so it's closer to what users get but not identical.min_distinct16, so it may have the same dark-scene problem. No L1C scene has been rendered yet.How this was made
Claude Code wrote the fixes and tests from the bug list in the 4 Nov handoff. Measuring real tiles showed the TI03 fix listed there wasn't enough, and an agent panel found that TI03 was testing a stretch no item link uses. @lhoupert chose to test both the links' and the Explorer's stretches and accepted the scale-error trade-off; @lhoupert's review of the code is pending. Independent
/code-reviewpasses found most of what the later commits fix. Tested locally withuv sync --extra readeranduv run pytest(174 passed, including the real titiler-eopf app at v0.12.4) andpip-auditon the lock (no known vulnerabilities); this repo's CI runs security checks only. Each new rule's test was checked against a mutant of that rule. Store and titiler checks with a local v0.12.4, reading EODC only, on the committed config: T33WWP, T33WXQ, T27SVC, T27SVB, T35WNU and T25WFP all pass overall. Not run against /rstaging, titiler 0.11 (/raster) or real faulty stores, and TR01 skips on https stores.