Allow copying chat lines when translating using /ctranslate#802
Open
xpple wants to merge 3 commits into
Open
Conversation
Earthcomputer
requested changes
Jul 20, 2026
|
|
||
| @Inject(method = "onEdited", at = @At("TAIL")) | ||
| private void onEdited(String value, CallbackInfo ci) { | ||
| this.isTranslating = value.startsWith(Commands.COMMAND_PREFIX + TranslateCommand.LITERAL); |
Owner
There was a problem hiding this comment.
Storing this isTranslated boolean and keeping it up-to-date seems like unnecessary complexity and opportunity to get out of sync after a port to a new Minecraft version. May as well get the text of the chat box and check if it starts with the translate command inside of tryCopy
Collaborator
Author
There was a problem hiding this comment.
It's kept up to date in onEdited, which is kind of the purpose of that method (hook for changes). It cannot really get out of sync because the Mixin injection would fail. Checking it in tryCopy would also be a bit less efficient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.