fix(cpn): recreate QAudioOutput per playback to fix silent preview on macOS#7516
Open
rickard-von-essen wants to merge 1 commit into
Open
fix(cpn): recreate QAudioOutput per playback to fix silent preview on macOS#7516rickard-von-essen wants to merge 1 commit into
rickard-von-essen wants to merge 1 commit into
Conversation
… macOS Shared QAudioOutput was created once and reused across QMediaPlayer instances. On macOS/AVFoundation, deleteLater() leaves the old player alive long enough that the new player cannot claim the same audio output, so nothing plays. Fix by creating QAudioOutput as a child of each new QMediaPlayer so it is always fresh and auto-deleted with the player. Also fixes a memory leak: the old audioOutput had no parent and was never deleted. Fixes EdgeTX#7354 Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
👮 Files not reviewed due to content moderation or server errors (1)
📝 Walkthrough
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shared QAudioOutput was created once and reused across QMediaPlayer instances. On macOS/AVFoundation, deleteLater() leaves the old player alive long enough that the new player cannot claim the same audio output, so nothing plays. Fix by creating QAudioOutput as a child of each new QMediaPlayer so it is always fresh and auto-deleted with the player.
Also fixes a memory leak: the old audioOutput had no parent and was never deleted.
Fixes #7354