Repository navigation
Add custom CSS, editor styles and custom JS under Settings > System > Design - #461
Merged
Merged
Conversation
… Design Admins can store SCSS, compiled on save, and styles for the editor's style menu. Documents, mails, knowledge base articles and text units let those classes through when rendering, the PDF gets their CSS, and the knowledge base sanitizer keeps efs- classes. Custom JS for head and body end needs full_admin, because such a script acts in every session. Everything is served from /theme/<hash>.css|js without login and with an immutable cache header, so a later CSP can allow 'self' without inline scripts. The code goes in at the end of head and body of the admin and desk layouts, login, verify and the document view; eNOTF and fireTab load none. ?safemode=1 turns it off for the session. Every change writes an audit entry with the hashes before and after, not the code. The values live in intra_config as non-editable rows, written through the new ConfigManager::set(). Needs emergencyforge/theme 0.1 and editor-php 0.11 from WebPackages.
WebPackages tagged 0.11.0 for the i18n release, so the style menu ships as editor 0.12.0. The dist comes from that tree.
# Conflicts: # composer.json # composer.lock # public/assets/dist/editor.css # public/assets/dist/editor.iife.js
# Conflicts: # CHANGELOG.md
itshypax
marked this pull request as ready for review
November 15, 2026 10:44
✅ Alle Checks bestanden25 Dateien geändert · Übersicht
Unit Tests ✅
Integration Tests ✅
Feature Tests (HTTP) ✅
Frontend Build ✅
PHPStan: Statische Analyse ✅
Security Audit ✅
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New page Settings > System > Design with three parts: custom SCSS, editor styles and custom JS. Built on
emergencyforge/theme0.1 and editor 0.12 from EmergencyForge/WebPackages#44. Lex gets the same in EmergencyForge/Lex#69.efs-classes.system.admin, JS also needsfull_admin(Admin+), otherwise 403./theme/<hash>.css|jsserves the code with an immutable cache header and works without login.?safemode=1switches custom CSS and JS off for the session, a yellow bar ends it.head.php, because fireTab and the eNOTF settings include that head and stay without custom code.20261115000001_insert_config_custom_codeadds the five keys as non-editabledesignrows, written through the newConfigManager::set().Checked: new
DesignSettingsTest(7), PHPStan, full suite in theintrarp-appimage (2174, the only failures are the SystemUpdater tests, which pass withIGNIS_RUNTIMEcleared). Not checked in the browser yet: login here is OAuth only.Draft until WebPackages#44 is merged and tagged (
editor/v0.12.0,theme/v0.1.0). Then.github/webpackages-ref, composer.lock and the dist follow in this branch, so CI fails until then.