Skip to content

Drop the Discord and Sync button from the login page in the game - #463

Merged
itshypax merged 1 commit into
mainfrom
fix/tablet-login-game-browser
Nov 15, 2026
Merged

itshypax merged 1 commit into
mainfrom
fix/tablet-login-game-browser

Conversation

@itshypax

Copy link
Copy Markdown
Collaborator

Same fix as EmergencyForge/Lex#72, which is merged. There the report from live play was: tapping "Anmelden" in the tablet gives a black screen, and only a resource restart helps. ignis has the same flow.

Without a session the ef_bridge tablet shows login.php. The "Mit Sync/Discord anmelden" button and the registration code form lead to Discord (X-Frame-Options: DENY) or to fabrica's /api/auth/instance/authorize (frame-ancestors 'none'). The browser blocks that inside the tablet frame, CEF shows no error page, and the frame stays dark until the resource restarts.

For a user agent with CitizenFX (FiveMSupport::isCitizenFx(), which FiveM's CEF sets for the NUI frame and the DUI), the page now leaves out the button, the code form and the registration notes. In their place it says "Im Spiel meldet dich das Tablet selbst an. Klappt das nicht, schließe das Tablet und öffne es erneut." The ef_tablet_signed_out signal to ef_bridge is unchanged. A normal browser sees no difference.

New test TabletLoginTest::im_spiel_zeigt_die_login_seite_keinen_discord_oder_sync_knopf, which fails without the change. The full suite passes locally except three tests that fail the same way without this change: ComposeProdTest, MysqlDsnTest::ohne_db_port_gilt_3306 and TrainingUpkeepTest::converter_attaches_the_pdf_and_marks_failures. Not tried in the game.

The DUI side (tablet held in the hand) is in EmergencyForge/ef_bridge#37.

Without a session the ef_bridge tablet shows the normal login page. Its
button, and the registration code form, lead to Discord or to the
fabrica authorize endpoint, and both refuse to be framed
(X-Frame-Options DENY, frame-ancestors 'none'). CEF shows no error page
for that, so the tablet frame stayed dark until the resource restarted.

For a CitizenFX user agent the page now leaves out the button, the code
form and the registration notes, and tells the player that the tablet
signs them in and to reopen it if that fails. The signal to ef_bridge
stays.
@emergencyforge

Copy link
Copy Markdown

✅ Alle Checks bestanden

2 Dateien geändert · +25 -3

Übersicht

Check Status Details
Build (PHP 8.3/8.4) ✅ Bestanden
Unit Tests (8.3/8.4) ✅ Bestanden Keine Tests
Integration Tests ✅ Bestanden Keine Tests
Feature Tests (HTTP) ✅ Bestanden Keine Tests
Frontend Build ✅ Bestanden
Security Audit ✅ Bestanden
PHPStan ✅ Bestanden

Unit Tests ✅

✅ 0 Tests bestanden.

Integration Tests ✅

✅ 0 Tests bestanden.

Feature Tests (HTTP) ✅

✅ 0 Tests bestanden.

Frontend Build ✅

Assets in Sync mit Source (SCSS + Vite gebaut, kein Diff).

PHPStan: Statische Analyse ✅

Keine Fehler gefunden.

Security Audit ✅

Keine bekannten Schwachstellen.


Workflow-Log ansehen

@itshypax
itshypax merged commit dac7c67 into main Nov 15, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant