Repository navigation
Drop the Discord and Sync button from the login page in the game - #463
Merged
Merged
Conversation
Without a session the ef_bridge tablet shows the normal login page. Its button, and the registration code form, lead to Discord or to the fabrica authorize endpoint, and both refuse to be framed (X-Frame-Options DENY, frame-ancestors 'none'). CEF shows no error page for that, so the tablet frame stayed dark until the resource restarted. For a CitizenFX user agent the page now leaves out the button, the code form and the registration notes, and tells the player that the tablet signs them in and to reopen it if that fails. The signal to ef_bridge stays.
✅ Alle Checks bestanden2 Dateien geändert · Übersicht
Unit Tests ✅
Integration Tests ✅
Feature Tests (HTTP) ✅
Frontend Build ✅
PHPStan: Statische Analyse ✅
Security Audit ✅
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same fix as EmergencyForge/Lex#72, which is merged. There the report from live play was: tapping "Anmelden" in the tablet gives a black screen, and only a resource restart helps. ignis has the same flow.
Without a session the ef_bridge tablet shows
login.php. The "Mit Sync/Discord anmelden" button and the registration code form lead to Discord (X-Frame-Options: DENY) or to fabrica's/api/auth/instance/authorize(frame-ancestors 'none'). The browser blocks that inside the tablet frame, CEF shows no error page, and the frame stays dark until the resource restarts.For a user agent with
CitizenFX(FiveMSupport::isCitizenFx(), which FiveM's CEF sets for the NUI frame and the DUI), the page now leaves out the button, the code form and the registration notes. In their place it says "Im Spiel meldet dich das Tablet selbst an. Klappt das nicht, schließe das Tablet und öffne es erneut." Theef_tablet_signed_outsignal to ef_bridge is unchanged. A normal browser sees no difference.New test
TabletLoginTest::im_spiel_zeigt_die_login_seite_keinen_discord_oder_sync_knopf, which fails without the change. The full suite passes locally except three tests that fail the same way without this change:ComposeProdTest,MysqlDsnTest::ohne_db_port_gilt_3306andTrainingUpkeepTest::converter_attaches_the_pdf_and_marks_failures. Not tried in the game.The DUI side (tablet held in the hand) is in EmergencyForge/ef_bridge#37.