Repository navigation
Pin WebPackages editor/v0.13.0 and allow a self-hosted LiveKit server - #464
Merged
Merged
Conversation
Moves editor-php to 0.13 and training to 0.7, and rebuilds the dist from that state. The ui modules now take their texts from the ui language files (German by default), and training 0.7 brings LiveKitServer for the next commit.
Screen sharing in presentations so far always took its room tokens from the EmergencyForge console. With LIVEKIT_URL, LIVEKIT_API_KEY and LIVEKIT_API_SECRET in .env, ignis now signs the tokens itself and the stream runs over the operator's own server. If only some of the three values are set, ignis logs the problem and keeps using the console, so a typo does not break screen sharing. The share button tooltip says which server is in use; the JS reads that text from the button instead of hardcoding the console wording.
✅ Alle Checks bestanden55 Dateien geändert · Übersicht
Unit Tests ✅
Integration Tests ✅
Feature Tests (HTTP) ✅
Frontend Build ✅
PHPStan: Statische Analyse ✅
Security Audit ✅
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin
.github/webpackages-refmoves toeditor/v0.13.0, editor-php to^0.13, training to^0.7, withcomposer.lockand the dist rebuilt from that state. The ui modules now take their texts from the ui language files, German by default; that is where the 43 changed files underpublic/assets/js/uiand the new_i18n.jscome from.Editor 0.13 has an emoji picker, but it only shows up with
emojiData. ignis passes none, so the editors look the same as before.Own LiveKit server
Screen sharing in presentations used to get its room tokens only from the EmergencyForge console. With
LIVEKIT_URL,LIVEKIT_API_KEYandLIVEKIT_API_SECRETin.env, ignis signs them itself throughLiveKitServerfrom training 0.7.Presentations::roomTokens()picks the source: own server first, otherwise the console viaAiDrafts::client(). If only some of the three values are set, ignis writes an error to the log and keeps the console.The share button tooltip says "Über den eigenen Medienserver" or "Über den Medienserver von EmergencyForge".
presentation.jsused to overwrite it with the console text; it now reads the server's text fromdata-livekit-tip.Setup guide for operators: EmergencyForge/Wiki#6. Same change in Lex: EmergencyForge/Lex#74.
Checked
TrainingPresentationTest: 91 green, including two new ones (own server signs a viewer token without asking the console, half a setup falls back to the console).IGNIS_RUNTIMEfrom the container image and pass on the host. The other two (GlobalAnnouncementManagerTest,MciBoardTest) depend on the announcement cache in that container.phpstan: no errors.