Skip to content

harden: add parameterized queries in infantry_sequence.js - #1

Merged
FS-21 merged 1 commit into
FS-21:mainfrom
anupamme:fix-repo-advanced-shp-editor-infantry-sequence-html-injection
Sep 15, 2026
Merged

FS-21 merged 1 commit into
FS-21:mainfrom
anupamme:fix-repo-advanced-shp-editor-infantry-sequence-html-injection

Conversation

@anupamme

Copy link
Copy Markdown
Contributor

Summary

Harden input handling in js/infantry_sequence.js (flagged by semgrep).

Vulnerability

Field Value
ID utils.custom.sql-injection-template-literal
Severity HIGH
Scanner semgrep
Rule utils.custom.sql-injection-template-literal
File js/infantry_sequence.js:692
Assessment Defensive hardening

Description: SQL query constructed using JavaScript template literals with dynamic input. This can lead to SQL injection. Use parameterized queries instead.

Changes

  • js/infantry_sequence.js

Behavior Preservation

The change is scoped to 1 file on the vulnerable path.


This patch removes an exploit primitive — a code pattern that, while not independently exploitable today, could be chained with other weaknesses by automated exploit-development tooling. Proactive removal of such primitives raises the bar against increasingly capable automated attack tools.


Automated security fix by OrbisAI Security

Automated security fix generated by OrbisAI Security
@FS-21
FS-21 merged commit cac3d18 into FS-21:main Sep 15, 2026
3 checks passed
@FS-21

FS-21 commented Sep 16, 2026

Copy link
Copy Markdown
Owner

created a new release, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants