[github-actions]

Adds fpp-plugin-RemoteBackup to pluginList.json, requested in #265.

Plugin repo: https://github.com/bobreese/fpp-plugin-RemoteBackup
pluginInfo.json: https://raw.githubusercontent.com/bobreese/fpp-plugin-RemoteBackup/refs/heads/master/pluginInfo.json
Category: Monitoring & System Tools
Submitted by: @bobreese
Registered owner (from srcURL): @bobreese (matches submitter)

⚠️ Opened despite 1 unresolved finding(s) below - the reporter used /submit to ask for review anyway rather than fix them first:

• ⚠️ Best practice - outside-plugin-territory - file path outside the plugin's own directory/log/config/playlists territory (ajax.php:521: $old = '/home/fpp/media/.fpp-plugin-RemoteBackup-settings.bak';).
  • Store plugin-owned files inside the plugin's own directory (${PLUGINDIR}/fpp-plugin-RemoteBackup/...), FPP's config storage (/media/config/), or the log directory (a real .log file only), rather than loose under /home/fpp/media/ itself

Schema, category, and archived/issues-disabled were already checked before this PR existed.

Merging is entirely up to a maintainer's judgement - this PR being open is not an approval, especially if it was opened via /submit over unresolved findings above.

⚠️ Before merging: install this plugin on a real (or test) FPP instance and visually inspect it - the automated check only covers what it can grep for. Confirm the UI actually renders correctly in both light and dark theme, nothing looks broken, and there's nothing the automated findings above wouldn't catch (ads, phone-home, donation links, ...).

A repo maintainer (or @bobreese) can comment /recheck here to re-run the plugin check against the repo's current state and refresh the findings above.

[bobreese]

/recheck
Added the privacy declaration.

[github-actions]

🔄 Recheck

Plugin: fpp-plugin-RemoteBackup
Repo: https://github.com/bobreese/fpp-plugin-RemoteBackup
Owner: bobreese

Requested by @bobreese - 3 issue(s) currently outstanding:

• 🛑 Blocker - schema - pluginInfo.json fails schema at (root): Additional properties are not allowed ('privacy' was unexpected)
• ⚠️ Best practice - sudo - uses sudo in a script (scripts/fpp_uninstall.sh:236: # sudo, not plain rm: same reasoning as delete_backup.sh's own fix -) - install/hooks already run as root.
  • Remove the sudo call and run the command directly, e.g. # sudo, not plain rm: same reasoning as delete_backup.sh's own fix -
• ⚠️ Best practice - outside-plugin-territory - file path outside the plugin's own directory/log/config/playlists territory (ajax.php:555: $old = '/home/fpp/media/.fpp-plugin-RemoteBackup-settings.bak';).
  • Store plugin-owned files inside the plugin's own directory (${PLUGINDIR}/fpp-plugin-RemoteBackup/...), its runtime-data directory (/home/fpp/media/plugindata/fpp-plugin-RemoteBackup/), FPP's config storage (/media/config/, for the plugin.fpp-plugin-RemoteBackup settings file only), or the log directory (a real .log file only), rather than loose under /home/fpp/media/ itself

This comment reflects the repo's current state; it does not change the PR itself - merging is still a maintainer's call.

[bobreese]

/recheck
Changed the privacy declaration.

[github-actions]

🔄 Recheck

Plugin: fpp-plugin-RemoteBackup
Repo: https://github.com/bobreese/fpp-plugin-RemoteBackup
Owner: bobreese

Requested by @bobreese - 2 issue(s) currently outstanding:

• ⚠️ Best practice - sudo - uses sudo in a script (scripts/fpp_uninstall.sh:268: sudo rm -rf "$d") - install/hooks already run as root.
  • Remove the sudo call and run the command directly, e.g. rm -rf "$d"
• ⚠️ Best practice - privacy-text-length - 4 privacy text(s) exceed the install-dialog caps: sends[0].what (123 > 100), collects[0].what (402 > 100), collects[1].what (171 > 100), systemChanges[0].what (389 > 120). FPP shows these inline under each light, so long text is cut off.
  • Keep summary to 200 characters, sends[].what/why and collects[].what to 100, systemChanges[].what to 120; the detail goes in other

This comment reflects the repo's current state; it does not change the PR itself - merging is still a maintainer's call.

[bobreese]

/recheck
Changed the privacy declaration.

[github-actions]

🔄 Recheck

Plugin: fpp-plugin-RemoteBackup
Repo: https://github.com/bobreese/fpp-plugin-RemoteBackup
Owner: bobreese

Requested by @bobreese - 1 issue(s) currently outstanding:

• ⚠️ Best practice - sudo - uses sudo in a script (scripts/fpp_uninstall.sh:268: sudo rm -rf "$d") - install/hooks already run as root.
  • Remove the sudo call and run the command directly, e.g. rm -rf "$d"

This comment reflects the repo's current state; it does not change the PR itself - merging is still a maintainer's call.

[bobreese]

It's the same call we already made conditional (if [ "$(id -u)" -eq 0 ]) for the legitimate manual, non-root --purge-backups case. The checker does a plain-text scan and has no way to see that guard, so it will always flag this line as long as sudo appears anywhere in that file

[darylc]

/recheck

[github-actions]

🔄 Recheck

Plugin: fpp-plugin-RemoteBackup
Repo: https://github.com/bobreese/fpp-plugin-RemoteBackup
Owner: bobreese

Requested by @darylc - 1 issue(s) currently outstanding:

• ⚠️ Best practice - sudo - uses sudo in a script (scripts/fpp_uninstall.sh:268: sudo rm -rf "$d") - install/hooks already run as root.
  • Remove the sudo call and run the command directly, e.g. rm -rf "$d"

This comment reflects the repo's current state; it does not change the PR itself - merging is still a maintainer's call.

[darylc]

/recheck

[github-actions]

🔄 Recheck

Plugin: fpp-plugin-RemoteBackup
Repo: https://github.com/bobreese/fpp-plugin-RemoteBackup
Owner: bobreese

✅ Requested by @darylc - no blocking issues found.

This comment reflects the repo's current state; it does not change the PR itself - merging is still a maintainer's call.

[github-actions]

Plugin list validation

Checked 2 changed entries in pluginList.json.

✅ All checks passed. Ready for a maintainer to review.