Repository navigation
fix(Segments): Standardise regex matching in the PHP server-side SDK - #152
Open
linear-code[bot] wants to merge 1 commit into
Open
linear-code[bot] wants to merge 1 commit into
linear-code[bot] wants to merge 1 commit into
Conversation
Regex segment conditions now match from the start of the trait value, for every alternative, without requiring a full-string match. Generated with [Linear](https://linear.app/flagsmith/agent-session/a271d061-9f7c-4f8a-a88b-9225fe6e9d66) Co-authored-by: linear-code[bot] <222613912+linear-code[bot]@users.noreply.github.com>
Author
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
Author
|
@coderabbitai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local evaluation accepted a regex match anywhere in a trait value, so
prodputnonproductionin a segment. The documented behaviour is that a match must start at the beginning of the value but doesn't need to cover all of it. This applies to every alternative, soprod|devmatchesdevelopmentbut notnondev.Changes
A) modifier is used instead.Closes https://linear.app/flagsmith/issue/SDK-27/standardise-regex-matching-in-the-php-server-side-sdk
Review effort: 1/5