You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
chore(Flag Dependency): GA Flag Dependency - #8882
Flag dependencies are now enabled for everyone in SaaS and OSS, so the dashboard no longer checks the flag_dependencies or flag_dependencies_change_requests feature flags.
The Dependencies tab shows on every feature, including where change requests are enforced.
Change request diffs always show dependency changes.
The Flag Dependencies E2E test always runs.
Review effort: 1/5
How did you test this code?
ESLint passes on the changed files.
npm run typecheck reports no new errors; the errors in DiffChangeRequest.tsx and ChangeRequestDetailPage.tsx also fail on main.
Review was skipped as selected files did not have any reviewable changes.
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: ASSERTIVE
Plan: Advanced
Run ID: f85b5c57-36c8-4569-9c31-197e7063ffb3
Commits
Reviewing files that changed from the base of the PR and between a869fea and 40ec72a.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
Trigger review
Walkthrough
The changes remove flag_dependencies and flag_dependencies_change_requests checks from dependency tab access and dependency loading. The dependency end-to-end test no longer skips when flag_dependencies is disabled. Dependency loading still skips under its other existing conditions.
The change removes dependency feature-flag checks without changing save ordering or existing diff restrictions. Existing dependency-editing issues warrant fixes, but no new merge-blocking regression is established for this change.
- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Remove the `flag_dependencies` and `flag_dependencies_change_requests`
feature flags now that flag dependencies are enabled for everyone.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to GitHub limitations.
⚠️ Outside diff range comments (1)
Major · Start the automatic commit only after prerequisite staging… · feature-list-store.ts:709-714
frontend/common/stores/feature-list-store.ts:709-714 Major · Data Integrity & Integration · Heavy lift
Start the automatic commit only after prerequisite staging succeeds.
For a non-4-eyes save with staged prerequisite changes, the store dispatches commit without waiting for the prerequisite requests. prom resolves after the commit POST is sent, store.saved runs onSave, and onSave then calls dependencyChanges.stageInto(changeRequestId). Nothing orders the commit before the prerequisite requests.
If the commit completes first, the dependency endpoints reject later requests with ChangeRequestAlreadyCommittedError. stageInto then clears the staged prerequisites and shows a banner. The change request is committed without the intended prerequisite edits.
The commit must wait until staging returns without a failure. Blocking reviewer approval during staging is a separate correction for the 4-eyes path and does not fix this path.
Note
Follow-up findings are listed below so you can review them separately from inline comments.
Follow-ups (2)
Major (1)
Major · Block dependency edits while the flag is frozen for an experiment. · index.tsx:481
frontend/web/components/modals/create-feature/index.tsx:481 Major · Functional Correctness · Quick win
Block dependency edits while the flag is frozen for an experiment.
The Dependencies tab does not receive freeze, and canManage ignores it. Users can add or remove prerequisites on a flag in a running experiment. Direct edits move the new override to priority 0, which changes the values the experiment serves.
Suggested fix
Pass freeze to FeatureDependenciesTab in index.tsx, add it to the component props, and include it in the edit guard:
Minor · Show dependency changes for committed change requests that are not… · DiffChangeRequest.tsx:57
frontend/web/components/diff/DiffChangeRequest.tsx:57 Minor · Functional Correctness · Poor tradeoff
Show dependency changes for committed change requests that are not yet live.
For a committed change request, skipDependencies is true, so the dependency diff is never loaded. Scheduled changes that add or remove prerequisites are missing from the diff, while feature-state changes for the same request still appear.
Unverified finding
We couldn't verify this from the code. It is shown for review, not as a verified issue.
Removing the flags still leaves dependency loading gated on CREATE_CHANGE_REQUEST; the supplied hook returns no dependency changes when skipped. Reviewers who can approve but not create requests may therefore see an incomplete diff.
The reviewer can approve without seeing the prerequisite changes.
This can occur when: Such a reviewer opens a request containing dependency changes.
Review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 8a403c42-1b07-4c73-99da-58b7eb775ce1
Commits
Reviewing files that changed from the base of the PR and between 45cfd10 and a869fea.
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chorefront-endIssue related to the React Front End Dashboard
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
Bot
added
the
front-end
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Closes #8881
Flag dependencies are now enabled for everyone in SaaS and OSS, so the dashboard no longer checks the
flag_dependenciesorflag_dependencies_change_requestsfeature flags.Review effort: 1/5
How did you test this code?
npm run typecheckreports no new errors; the errors inDiffChangeRequest.tsxandChangeRequestDetailPage.tsxalso fail onmain.🤖 Generated with Claude Code