Repository navigation
[Reviewed] [3D light] Use the Three.js r185 light falloff on every GDevelop version - #2301
Merged
Merged
Conversation
…evelop version Point and spot lights now fade with the physically based falloff of Three.js r185 (used by recent GDevelop versions) on older GDevelop versions too, by patching their "legacy lights" shader. Lights then look the same whatever the GDevelop version. This is a breaking change: lights made for the previous versions need a higher intensity (and possibly a lower decay). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FXhdCRasV6YVFStxiKPZM8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Point and spot lights now fade with the physically based falloff of Three.js r185 (used by recent GDevelop versions) on older GDevelop versions too, by patching their "legacy lights" shader. Lights then look the same whatever the GDevelop version.