Repository navigation
Replace the combined GOCART2G regression cases with a single gocart case - #508
Open
pchakraborty wants to merge 1 commit into
Open
pchakraborty wants to merge 1 commit into
pchakraborty wants to merge 1 commit into
Conversation
The gocart+seasalt+dust+sulfate, ...+nitrate and ...+nitrate+carbon-bc cases are replaced by regression/gocart, which runs GOCART2G with the production set of children: DU, SS, SU, NI, CA_oc, CA_bc and CA_br. Adds CA2G_instance_CA_{oc,br}.yaml, extends cmpchk.py to the new children, and updates cases.txt and README.md. Updates the CA2G, NI2G and SU2G porting notes to match.
pchakraborty
marked this pull request as ready for review
November 16, 2026 19:43
|
This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the three combined GOCART2G regression cases (
gocart+seasalt+dust+sulfate,...+nitrate,...+nitrate+carbon-bc) with one case,regression/gocart. It runs GOCART2G with the production children: DU, SS, SU, NI, CA_oc, CA_bc and CA_br.CA2G_instance_CA_{oc,br}.yaml, and enablesCA: [CA_oc, CA_bc, CA_br]inGOCART2G_GridComp.yaml.cmpchk.pyto the new children, and updatescases.txtandregression/README.md.Verification:
gocart/run1andgocart/run2were run by hand (GEOS.x, 6 ranks, ifx Debug) against MAPL2 captures at C12L181, staged in~/regression-data. All children and theGOCART2G_exportmatch MAPL2, apart from fields that are all-NaN on both sides. In run1, GOCART2G's totals are NaN by design, because they are computed in run2.The baselines are not yet published to S3 or
/ford1, soctest -L REGRESSIONwill skipgocartuntil they are. The old combined cases' published data should be removed then.