Skip to content

Replace the combined GOCART2G regression cases with a single gocart case - #508

Open
pchakraborty wants to merge 1 commit into
release/MAPL-v3from
feature/pchakrab/single-gocart-regression-case
Open

pchakraborty wants to merge 1 commit into
release/MAPL-v3from
feature/pchakrab/single-gocart-regression-case

Conversation

@pchakraborty

Copy link
Copy Markdown
Collaborator

Replaces the three combined GOCART2G regression cases (gocart+seasalt+dust+sulfate, ...+nitrate, ...+nitrate+carbon-bc) with one case, regression/gocart. It runs GOCART2G with the production children: DU, SS, SU, NI, CA_oc, CA_bc and CA_br.

  • Adds CA2G_instance_CA_{oc,br}.yaml, and enables CA: [CA_oc, CA_bc, CA_br] in GOCART2G_GridComp.yaml.
  • Extends cmpchk.py to the new children, and updates cases.txt and regression/README.md.
  • Updates the CA2G, NI2G and SU2G porting notes.

Verification: gocart/run1 and gocart/run2 were run by hand (GEOS.x, 6 ranks, ifx Debug) against MAPL2 captures at C12L181, staged in ~/regression-data. All children and the GOCART2G_export match MAPL2, apart from fields that are all-NaN on both sides. In run1, GOCART2G's totals are NaN by design, because they are computed in run2.

The baselines are not yet published to S3 or /ford1, so ctest -L REGRESSION will skip gocart until they are. The old combined cases' published data should be removed then.

The gocart+seasalt+dust+sulfate, ...+nitrate and ...+nitrate+carbon-bc cases are replaced by regression/gocart, which runs GOCART2G with the production set of children: DU, SS, SU, NI, CA_oc, CA_bc and CA_br. Adds CA2G_instance_CA_{oc,br}.yaml, extends cmpchk.py to the new children, and updates cases.txt and README.md. Updates the CA2G, NI2G and SU2G porting notes to match.
@pchakraborty pchakraborty added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Nov 16, 2026
@pchakraborty
pchakraborty marked this pull request as ready for review November 16, 2026 19:43
@pchakraborty
pchakraborty requested a review from a team as a code owner November 16, 2026 19:43
@pchakraborty pchakraborty added the Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label Nov 16, 2026
@github-actions

Copy link
Copy Markdown

This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 diff The changes in this pull request have verified to be zero-diff with the target branch. Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant