Conversation
added 2 commits
July 27, 2026 20:20
@bacons/apple-targets reads ios.appleTeamId to stamp DEVELOPMENT_TEAM onto the targets it generates. The field was never set, so prebuild took the "no team anywhere" branch: it strips DEVELOPMENT_TEAM from every target and writes the literal `DevelopmentTeam = undefined;` into TargetAttributes. It also warns "iOS builds may fail until this is corrected" on every CI prebuild. Sourced from EXPO_APPLE_TEAM_ID so the id stays out of the repo. Also corrects release-mobile.yml's CREDENTIALS block, which predicted the wrong failure. EAS sets iOS credentials up per target, and in non-interactive mode SetUpDistributionCertificate can only reuse a certificate already assigned to that target: no branch adopts an unassigned account certificate and none creates one. An ASC API key does not help, since the rc1 run was already using one when it failed at the certificate lookup, and it cannot link App Group identifiers at all. The build step now names the target and the command to run instead of leaving eas-cli's bare "run this command again in interactive mode". Refs #104 Claude-Session: https://claude.ai/code/session_01QsVEsfkynXpJWK4t33exG9
…ne is absent pipefail plus the job shell's -e meant a no-match grep would kill the step before it printed the annotation it exists to print. Refs #104 Claude-Session: https://claude.ai/code/session_01QsVEsfkynXpJWK4t33exG9
Owner
Author
|
The extension targets are staying out, so this signing patch has nothing left to fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reopens #109 with the same diff, merged without review and reverted in #124. Only makes sense again together with the widget and notification PRs.