Skip to content

feat(middle-click): Add in GUI and in-world middle-click pick to set and reset channels - #74

Merged
Glease merged 7 commits into
masterfrom
feat/middle-click
Sep 21, 2026
Merged

Glease merged 7 commits into
masterfrom
feat/middle-click

Conversation

@vermz99

@vermz99 vermz99 commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Summary

Similar to GTNewHorizons/MatterManipulator#84 and GTNewHorizons/LittleTiles#163

  • Implemented middle-click pick to set channels on the Hologram Projector. I've reused what was already done for the drag and drop feature.
  • Middle click works for in-ui and in-world.
  • Shift+middle click will clear all channels from the hologram projector
hologram-in-ui hologram-in-world

Note

I'm not a fan of having all authority on client side, but that was already done this way. I made the handler agnostic so at some point if we want to send the whole validation on the server too, it'll be possible.

Checklist

  • I have tested this PR in DevEnv
  • I have tested this PR in Fullpack
  • This PR is in compliance with the GTNH AI Policy
  • This PR requires another PR in order to merge

@vermz99 vermz99 self-assigned this Sep 17, 2026
@vermz99
vermz99 requested a review from Glease September 17, 2026 02:42
@vermz99
vermz99 requested a review from a team September 17, 2026 14:22

@Glease Glease left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature but the implementation has a number of issues

Comment thread src/main/java/com/gtnewhorizon/structurelib/util/BogoCompat.java Outdated
Comment thread src/main/java/com/gtnewhorizon/structurelib/ClientProxy.java Outdated
Comment thread src/main/java/com/gtnewhorizon/structurelib/core/StructureLibCore.java Outdated
Comment thread src/main/java/com/gtnewhorizon/structurelib/util/MiscUtils.java Outdated
Comment thread src/main/java/com/gtnewhorizon/structurelib/ChannelPickHandler.java Outdated
Comment thread src/main/java/com/gtnewhorizon/structurelib/ChannelPickHandler.java
@vermz99
vermz99 requested a review from Glease September 20, 2026 19:57
Comment thread dependencies.gradle Outdated

@Glease Glease left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Glease
Glease merged commit 4fdea65 into master Sep 21, 2026
1 check passed
@Glease
Glease deleted the feat/middle-click branch September 21, 2026 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants