feat: allow augmenting event types#1784
Merged
Merged
Conversation
Contributor
|
Size Change: 0 B Total Size: 408 kB ℹ️ View Unchanged
|
oliverlaz
approved these changes
Jun 23, 2026
isekovanic
approved these changes
Jun 23, 2026
isekovanic
left a comment
Contributor
There was a problem hiding this comment.
Thanks Matvei !
@arnautov-anton this might be relevant for you I believe and the work with OpenAPI.
Nice next step, but out of scope for this PR, is strongly typing event data based on event type - both for internal and custom events.
This is something that'll come in the next major (~October) given our OpenAPI integration. To do it now is unfortunately breaking for types. But hold on a bit longer !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLA
Description of the changes, What, Why and How?
Adds a new exported interface
CustomEventTypes. It should be a map where keys are custom event type strings. That allows augmenting SDK'sEventTypesunion with more types:Useful in combination with
CustomEventData.Nice next step, but out of scope for this PR, is strongly typing event data based on event type - both for internal and custom events.