Skip to content

Promote IAP Agent, MCP Server and Endpoint resources to GA#18088

Draft
swamitagupta wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
swamitagupta:promote-iap-ar-children
Draft

Promote IAP Agent, MCP Server and Endpoint resources to GA#18088
swamitagupta wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
swamitagupta:promote-iap-ar-children

Conversation

@swamitagupta

Copy link
Copy Markdown
Member

Promote IAP Agent Registry resources to GA

Key Modifications:

  • Promote IAP resources: Introduce IAP Agent, MCP Server, and Endpoint resources to the GA provider.
  • Add example templates: Add terraform example templates to fetch the parent agent registry data sources.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_iap_agent_registry_agent_iam_binding`
`google_iap_agent_registry_agent_iam_member`
`google_iap_agent_registry_agent_iam_policy` 
`google_iap_agent_registry_endpoint_iam_binding`
`google_iap_agent_registry_endpoint_iam_member`
`google_iap_agent_registry_endpoint_iam_policy` 
`google_iap_agent_registry_mcp_server_iam_binding`
`google_iap_agent_registry_mcp_server_iam_member`
`google_iap_agent_registry_mcp_server_iam_policy` 

@modular-magician

modular-magician commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 35e7b49:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 12 files changed, 3876 insertions(+)
google-beta provider View Diff 12 files changed, 3876 insertions(+)

Multiple resources added

This PR adds multiple new resources: google_iap_agent_registry_agent_iam_*, google_iap_agent_registry_endpoint_iam_*, google_iap_agent_registry_mcp_server_iam_*. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

Test report

Important

Manual Verification Required

VCR cannot automatically execute the following tests added in this PR. Please verify them manually:

🔴 TestAccIapAgentRegistryAgentIamBindingGenerated_withAndWithoutCondition
🔴 TestAccIapAgentRegistryAgentIamMemberGenerated_withAndWithoutCondition
🔴 TestAccIapAgentRegistryEndpointIamBindingGenerated_withAndWithoutCondition
🔴 TestAccIapAgentRegistryEndpointIamMemberGenerated_withAndWithoutCondition
🔴 TestAccIapAgentRegistryMcpServerIamBindingGenerated_withAndWithoutCondition
🔴 TestAccIapAgentRegistryMcpServerIamMemberGenerated_withAndWithoutCondition

Analytics

Total Tests Passed Skipped Affected
145 93 34 18
Affected Service Packages
  • iap

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 18 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccIapAgentRegistryAgentIamBindingGenerated
  • TestAccIapAgentRegistryAgentIamBindingGenerated_withCondition
  • TestAccIapAgentRegistryAgentIamMemberGenerated
  • TestAccIapAgentRegistryAgentIamMemberGenerated_withCondition
  • TestAccIapAgentRegistryAgentIamPolicyGenerated
  • TestAccIapAgentRegistryAgentIamPolicyGenerated_withCondition
  • TestAccIapAgentRegistryEndpointIamBindingGenerated
  • TestAccIapAgentRegistryEndpointIamBindingGenerated_withCondition
  • TestAccIapAgentRegistryEndpointIamMemberGenerated
  • TestAccIapAgentRegistryEndpointIamMemberGenerated_withCondition
  • TestAccIapAgentRegistryEndpointIamPolicyGenerated
  • TestAccIapAgentRegistryEndpointIamPolicyGenerated_withCondition
  • TestAccIapAgentRegistryMcpServerIamBindingGenerated
  • TestAccIapAgentRegistryMcpServerIamBindingGenerated_withCondition
  • TestAccIapAgentRegistryMcpServerIamMemberGenerated
  • TestAccIapAgentRegistryMcpServerIamMemberGenerated_withCondition
  • TestAccIapAgentRegistryMcpServerIamPolicyGenerated
  • TestAccIapAgentRegistryMcpServerIamPolicyGenerated_withCondition

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccIapAgentRegistryAgentIamBindingGenerated_withCondition
❌ Error · Log - TestAccIapAgentRegistryAgentIamBindingGenerated
❌ Error · Log - TestAccIapAgentRegistryAgentIamMemberGenerated
❌ Error · Log - TestAccIapAgentRegistryAgentIamMemberGenerated_withCondition
❌ Error · Log - TestAccIapAgentRegistryAgentIamPolicyGenerated
❌ Error · Log - TestAccIapAgentRegistryAgentIamPolicyGenerated_withCondition
❌ Error · Log - TestAccIapAgentRegistryEndpointIamBindingGenerated
❌ Error · Log - TestAccIapAgentRegistryEndpointIamBindingGenerated_withCondition
❌ Error · Log - TestAccIapAgentRegistryEndpointIamMemberGenerated
❌ Error · Log - TestAccIapAgentRegistryEndpointIamMemberGenerated_withCondition
❌ Error · Log - TestAccIapAgentRegistryEndpointIamPolicyGenerated
❌ Error · Log - TestAccIapAgentRegistryEndpointIamPolicyGenerated_withCondition
❌ Error · Log - TestAccIapAgentRegistryMcpServerIamBindingGenerated
❌ Error · Log - TestAccIapAgentRegistryMcpServerIamBindingGenerated_withCondition
❌ Error · Log - TestAccIapAgentRegistryMcpServerIamMemberGenerated
❌ Error · Log - TestAccIapAgentRegistryMcpServerIamMemberGenerated_withCondition
❌ Error · Log - TestAccIapAgentRegistryMcpServerIamPolicyGenerated
❌ Error · Log - TestAccIapAgentRegistryMcpServerIamPolicyGenerated_withCondition

Caution

Issues requiring attention before PR completion

🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details.

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@swamitagupta VCR tests complete for 35e7b49!

@swamitagupta swamitagupta force-pushed the promote-iap-ar-children branch from 35e7b49 to 9e0f36c Compare June 26, 2026 00:16
@modular-magician

modular-magician commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 9e0f36c:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 12 files changed, 4046 insertions(+)
google-beta provider View Diff 12 files changed, 4046 insertions(+)

Multiple resources added

This PR adds multiple new resources: google_iap_agent_registry_agent_iam_*, google_iap_agent_registry_endpoint_iam_*, google_iap_agent_registry_mcp_server_iam_*. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

Test report

Important

Manual Verification Required

VCR cannot automatically execute the following tests added in this PR. Please verify them manually:

🔴 TestAccIapAgentRegistryAgentIamBindingGenerated_withAndWithoutCondition
🔴 TestAccIapAgentRegistryAgentIamMemberGenerated_withAndWithoutCondition
🔴 TestAccIapAgentRegistryEndpointIamBindingGenerated_withAndWithoutCondition
🔴 TestAccIapAgentRegistryEndpointIamMemberGenerated_withAndWithoutCondition
🔴 TestAccIapAgentRegistryMcpServerIamBindingGenerated_withAndWithoutCondition
🔴 TestAccIapAgentRegistryMcpServerIamMemberGenerated_withAndWithoutCondition

Analytics

Total Tests Passed Skipped Affected
145 94 34 17
Affected Service Packages
  • iap

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccIapAgentRegistryAgentIamBindingGenerated
  • TestAccIapAgentRegistryAgentIamMemberGenerated
  • TestAccIapAgentRegistryAgentIamMemberGenerated_withCondition
  • TestAccIapAgentRegistryAgentIamPolicyGenerated
  • TestAccIapAgentRegistryAgentIamPolicyGenerated_withCondition
  • TestAccIapAgentRegistryEndpointIamBindingGenerated
  • TestAccIapAgentRegistryEndpointIamBindingGenerated_withCondition
  • TestAccIapAgentRegistryEndpointIamMemberGenerated
  • TestAccIapAgentRegistryEndpointIamMemberGenerated_withCondition
  • TestAccIapAgentRegistryEndpointIamPolicyGenerated
  • TestAccIapAgentRegistryEndpointIamPolicyGenerated_withCondition
  • TestAccIapAgentRegistryMcpServerIamBindingGenerated
  • TestAccIapAgentRegistryMcpServerIamBindingGenerated_withCondition
  • TestAccIapAgentRegistryMcpServerIamMemberGenerated
  • TestAccIapAgentRegistryMcpServerIamMemberGenerated_withCondition
  • TestAccIapAgentRegistryMcpServerIamPolicyGenerated
  • TestAccIapAgentRegistryMcpServerIamPolicyGenerated_withCondition

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccIapAgentRegistryAgentIamBindingGenerated
✅ Log TestAccIapAgentRegistryAgentIamMemberGenerated
✅ Log TestAccIapAgentRegistryAgentIamMemberGenerated_withCondition
✅ Log TestAccIapAgentRegistryMcpServerIamBindingGenerated_withCondition
✅ Log TestAccIapAgentRegistryMcpServerIamMemberGenerated_withCondition
❌ Error · Log - TestAccIapAgentRegistryAgentIamPolicyGenerated
❌ Error · Log - TestAccIapAgentRegistryAgentIamPolicyGenerated_withCondition
❌ Error · Log - TestAccIapAgentRegistryEndpointIamBindingGenerated
❌ Error · Log - TestAccIapAgentRegistryEndpointIamBindingGenerated_withCondition
❌ Error · Log - TestAccIapAgentRegistryEndpointIamMemberGenerated
❌ Error · Log - TestAccIapAgentRegistryEndpointIamMemberGenerated_withCondition
❌ Error · Log - TestAccIapAgentRegistryEndpointIamPolicyGenerated
❌ Error · Log - TestAccIapAgentRegistryEndpointIamPolicyGenerated_withCondition
❌ Error · Log - TestAccIapAgentRegistryMcpServerIamBindingGenerated
❌ Error · Log - TestAccIapAgentRegistryMcpServerIamMemberGenerated
❌ Error · Log - TestAccIapAgentRegistryMcpServerIamPolicyGenerated
❌ Error · Log - TestAccIapAgentRegistryMcpServerIamPolicyGenerated_withCondition

Caution

Issues requiring attention before PR completion

🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details.

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@swamitagupta VCR tests complete for 9e0f36c!

@swamitagupta swamitagupta force-pushed the promote-iap-ar-children branch from 9e0f36c to 320d000 Compare June 26, 2026 01:10
@modular-magician

modular-magician commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 320d000:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 12 files changed, 4130 insertions(+)
google-beta provider View Diff 12 files changed, 4130 insertions(+)

Multiple resources added

This PR adds multiple new resources: google_iap_agent_registry_agent_iam_*, google_iap_agent_registry_endpoint_iam_*, google_iap_agent_registry_mcp_server_iam_*. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

Test report

Important

Manual Verification Required

VCR cannot automatically execute the following tests added in this PR. Please verify them manually:

🔴 TestAccIapAgentRegistryAgentIamBindingGenerated_withAndWithoutCondition
🔴 TestAccIapAgentRegistryAgentIamMemberGenerated_withAndWithoutCondition
🔴 TestAccIapAgentRegistryEndpointIamBindingGenerated_withAndWithoutCondition
🔴 TestAccIapAgentRegistryEndpointIamMemberGenerated_withAndWithoutCondition
🔴 TestAccIapAgentRegistryMcpServerIamBindingGenerated_withAndWithoutCondition
🔴 TestAccIapAgentRegistryMcpServerIamMemberGenerated_withAndWithoutCondition

Analytics

Total Tests Passed Skipped Affected
145 99 34 12
Affected Service Packages
  • iap

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccIapAgentRegistryAgentIamPolicyGenerated
  • TestAccIapAgentRegistryAgentIamPolicyGenerated_withCondition
  • TestAccIapAgentRegistryEndpointIamBindingGenerated
  • TestAccIapAgentRegistryEndpointIamBindingGenerated_withCondition
  • TestAccIapAgentRegistryEndpointIamMemberGenerated
  • TestAccIapAgentRegistryEndpointIamMemberGenerated_withCondition
  • TestAccIapAgentRegistryEndpointIamPolicyGenerated
  • TestAccIapAgentRegistryEndpointIamPolicyGenerated_withCondition
  • TestAccIapAgentRegistryMcpServerIamBindingGenerated
  • TestAccIapAgentRegistryMcpServerIamMemberGenerated
  • TestAccIapAgentRegistryMcpServerIamPolicyGenerated
  • TestAccIapAgentRegistryMcpServerIamPolicyGenerated_withCondition

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccIapAgentRegistryAgentIamPolicyGenerated_withCondition
❌ Error · Log - TestAccIapAgentRegistryAgentIamPolicyGenerated
❌ Error · Log - TestAccIapAgentRegistryEndpointIamBindingGenerated
❌ Error · Log - TestAccIapAgentRegistryEndpointIamBindingGenerated_withCondition
❌ Error · Log - TestAccIapAgentRegistryEndpointIamMemberGenerated
❌ Error · Log - TestAccIapAgentRegistryEndpointIamMemberGenerated_withCondition
❌ Error · Log - TestAccIapAgentRegistryEndpointIamPolicyGenerated
❌ Error · Log - TestAccIapAgentRegistryEndpointIamPolicyGenerated_withCondition
❌ Error · Log - TestAccIapAgentRegistryMcpServerIamBindingGenerated
❌ Error · Log - TestAccIapAgentRegistryMcpServerIamMemberGenerated
❌ Error · Log - TestAccIapAgentRegistryMcpServerIamPolicyGenerated
❌ Error · Log - TestAccIapAgentRegistryMcpServerIamPolicyGenerated_withCondition

Caution

Issues requiring attention before PR completion

🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details.

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@swamitagupta VCR tests complete for 320d000!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants