Skip to content

chore: delete datastore sample#4310

Open
iennae wants to merge 2 commits intomainfrom
iennae-patch-1
Open

chore: delete datastore sample#4310
iennae wants to merge 2 commits intomainfrom
iennae-patch-1

Conversation

@iennae
Copy link
Copy Markdown
Contributor

@iennae iennae commented May 8, 2026

Description

This sample has failing tests in another PR and doesn't look to be in use (no region tags)

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@iennae iennae requested review from a team as code owners May 8, 2026 00:32
@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: datastore Issues related to the Datastore API. asset: pattern DEE Asset tagging - Pattern. labels May 8, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the Google Cloud Functions Cloud Datastore sample project, deleting the source code, configuration files, documentation, and tests. I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastore Issues related to the Datastore API. asset: pattern DEE Asset tagging - Pattern. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants