Skip to content

Make the Gradient tool default to the primary/secondary working colors as its initial gradient#4119

Merged
Keavon merged 2 commits intomasterfrom
gradient-tool-working-colors
May 7, 2026
Merged

Make the Gradient tool default to the primary/secondary working colors as its initial gradient#4119
Keavon merged 2 commits intomasterfrom
gradient-tool-working-colors

Conversation

@Keavon
Copy link
Copy Markdown
Member

@Keavon Keavon commented May 7, 2026

No description provided.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables the gradient tool to use the global primary and secondary colors as defaults by introducing a WorkingColorChanged message and caching these colors in the tool's state. Reviewers suggested reversing the order of the default color stops to match the tool's drawing logic and updating the documentation to specify that the cached colors are in gamma space.

Comment thread editor/src/messages/tool/tool_messages/gradient_tool.rs
Comment thread editor/src/messages/tool/tool_messages/gradient_tool.rs
@Keavon Keavon merged commit 9512f7d into master May 7, 2026
10 checks passed
@Keavon Keavon deleted the gradient-tool-working-colors branch May 7, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant